Fix Table attribute incrementing not working for Pivot models (#59336)

* Fix Table attribute incrementing not working for Pivot models

The `#[Table]` attribute includes an argument to specify whether the primary key should be incrementing. However, for Pivot models that default to non-incrementing, the Table attribute's incrementing argument was not being applied because the logic only checked it when `$this->incrementing === true`.

This fix removes the outer condition so that the Table attribute can override the default incrementing behavior for all models, including Pivots.

* Update Model.php

---------

Co-authored-by: Taylor Otwell <taylor@laravel.com>

Author: sadique-cws

src/Illuminate/Database/Eloquent/Model.php

@@ -446,12 +446,10 @@ public function initializeModelAttributes()
             $this->keyType = $table->keyType;
         }
 
-        if ($this->incrementing === true) {
-            if (static::resolveClassAttribute(WithoutIncrementing::class) !== null) {
-                $this->incrementing = false;
-            } elseif ($table && $table->incrementing !== null) {
-                $this->incrementing = $table->incrementing;
-            }
+        if (static::resolveClassAttribute(WithoutIncrementing::class) !== null) {
+            $this->incrementing = false;
+        } elseif ($table && $table->incrementing !== null) {
+            $this->incrementing = $table->incrementing;
         }
     }
 

tests/Database/DatabaseEloquentModelAttributesTest.php

@@ -107,6 +107,13 @@ public function test_dedicated_without_incrementing_attribute_overrides_table_in
         $this->assertFalse($model->getIncrementing());
     }
 
+    public function test_table_attribute_incrementing_applies_to_pivot_models(): void
+    {
+        $model = new PivotWithIncrementing;
+
+        $this->assertTrue($model->getIncrementing());
+    }
+
     public function test_connection_attribute(): void
     {
         $model = new ModelWithConnectionAttribute;
@@ -504,3 +511,9 @@ class ModelWithWithoutIncrementingAttributeOverride extends Model
 {
     //
 }
+
+#[Table(incrementing: true)]
+class PivotWithIncrementing extends \Illuminate\Database\Eloquent\Relations\Pivot
+{
+    //
+}