Skip to content

Commit 09feffb

Browse files
committed
Merge remote-tracking branch 'upstream/6.x' into 6.x
2 parents 5c79528 + 00fa9c0 commit 09feffb

File tree

3 files changed

+2
-8
lines changed

3 files changed

+2
-8
lines changed

src/Illuminate/Foundation/Application.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ class Application extends Container implements ApplicationContract, HttpKernelIn
3131
*
3232
* @var string
3333
*/
34-
const VERSION = '6.20.28';
34+
const VERSION = '6.20.29';
3535

3636
/**
3737
* The base path for the Laravel installation.

src/Illuminate/Validation/Rules/RequiredIf.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class RequiredIf
2121
*/
2222
public function __construct($condition)
2323
{
24-
if (! is_string($condition) && (is_bool($condition) || is_callable($condition))) {
24+
if (! is_string($condition)) {
2525
$this->condition = $condition;
2626
} else {
2727
throw new InvalidArgumentException('The provided condition must be a callable or boolean.');

tests/Validation/ValidationRequiredIfTest.php

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,6 @@ public function testItOnlyCallableAndBooleanAreAcceptableArgumentsOfTheRule()
3939
$this->expectException(\InvalidArgumentException::class);
4040

4141
$rule = new RequiredIf('phpinfo');
42-
43-
$rule = new RequiredIf(12.3);
44-
45-
$rule = new RequiredIf(new stdClass());
4642
}
4743

4844
public function testItReturnedRuleIsNotSerializable()
@@ -52,7 +48,5 @@ public function testItReturnedRuleIsNotSerializable()
5248
$rule = serialize(new RequiredIf(function () {
5349
return true;
5450
}));
55-
56-
$rule = serialize(new RequiredIf());
5751
}
5852
}

0 commit comments

Comments
 (0)