[7.x] Slight optimization to mergeConfigFrom (#33493)

* Slight optimization to mergeConfigFrom

For cold starts and lumen, this avoids 2 magic method calls to ArrayInterface
and one make call which itself has a bit of logic. This should not
affect laravel with config caching but config is in a hot path for requests in
lumen it is a small change that could add up.

* Update ServiceProvider.php

* Update ServiceProvider.php

* Update ServiceProvider.php

Co-authored-by: Dries Vints <[email protected]>
Co-authored-by: Graham Campbell <[email protected]>
Co-authored-by: Taylor Otwell <[email protected]>

Author: 4 people

src/Illuminate/Support/ServiceProvider.php

@@ -63,8 +63,10 @@ public function register()
     protected function mergeConfigFrom($path, $key)
     {
         if (! ($this->app instanceof CachesConfiguration && $this->app->configurationIsCached())) {
-            $this->app['config']->set($key, array_merge(
-                require $path, $this->app['config']->get($key, [])
+            $config = $this->app->make('config');
+
+            $config->set($key, array_merge(
+                require $path, $config->get($key, [])
             ));
         }
     }