[10.x] Streamline DatabaseMigrations and RefreshDatabase events (#49153)

* [10.x] Test Improvements

Use available method from `RefreshDatabase::afterRefreshingDatabase()`

Signed-off-by: Mior Muhammad Zaki <[email protected]>

* wip

Signed-off-by: Mior Muhammad Zaki <[email protected]>

---------

Signed-off-by: Mior Muhammad Zaki <[email protected]>

Author: crynobone

src/Illuminate/Foundation/Testing/DatabaseMigrations.php

@@ -16,14 +16,46 @@ trait DatabaseMigrations
      */
     public function runDatabaseMigrations()
     {
-        $this->artisan('migrate:fresh', $this->migrateFreshUsing());
-
-        $this->app[Kernel::class]->setArtisan(null);
+        $this->beforeRefreshingDatabase();
+        $this->refreshTestDatabase();
+        $this->afterRefreshingDatabase();
 
         $this->beforeApplicationDestroyed(function () {
             $this->artisan('migrate:rollback');
 
             RefreshDatabaseState::$migrated = false;
         });
     }
+
+    /**
+     * Refresh a conventional test database.
+     *
+     * @return void
+     */
+    protected function refreshTestDatabase()
+    {
+        $this->artisan('migrate:fresh', $this->migrateFreshUsing());
+
+        $this->app[Kernel::class]->setArtisan(null);
+    }
+
+    /**
+     * Perform any work that should take place before the database has started refreshing.
+     *
+     * @return void
+     */
+    protected function beforeRefreshingDatabase()
+    {
+        // ...
+    }
+
+    /**
+     * Perform any work that should take place once the database has finished refreshing.
+     *
+     * @return void
+     */
+    protected function afterRefreshingDatabase()
+    {
+        // ...
+    }
 }

tests/Integration/Database/DatabaseCustomCastsTest.php

@@ -13,7 +13,7 @@
 
 class DatabaseCustomCastsTest extends DatabaseTestCase
 {
-    protected function defineDatabaseMigrationsAfterDatabaseRefreshed()
+    protected function afterRefreshingDatabase()
     {
         Schema::create('test_eloquent_model_with_custom_casts', function (Blueprint $table) {
             $table->increments('id');

tests/Integration/Database/DatabaseEloquentBroadcastingTest.php

@@ -18,7 +18,7 @@
 
 class DatabaseEloquentBroadcastingTest extends DatabaseTestCase
 {
-    protected function defineDatabaseMigrationsAfterDatabaseRefreshed()
+    protected function afterRefreshingDatabase()
     {
         Schema::create('test_eloquent_broadcasting_users', function (Blueprint $table) {
             $table->increments('id');

tests/Integration/Database/DatabaseEloquentModelAttributeCastingTest.php

@@ -12,7 +12,7 @@
 
 class DatabaseEloquentModelAttributeCastingTest extends DatabaseTestCase
 {
-    protected function defineDatabaseMigrationsAfterDatabaseRefreshed()
+    protected function afterRefreshingDatabase()
     {
         Schema::create('test_eloquent_model_with_custom_casts', function (Blueprint $table) {
             $table->increments('id');

tests/Integration/Database/DatabaseEloquentModelCustomCastingTest.php

@@ -16,7 +16,7 @@
 
 class DatabaseEloquentModelCustomCastingTest extends DatabaseTestCase
 {
-    protected function defineDatabaseMigrationsAfterDatabaseRefreshed()
+    protected function afterRefreshingDatabase()
     {
         Schema::create('test_eloquent_model_with_custom_casts', function (Blueprint $table) {
             $table->increments('id');

tests/Integration/Database/EloquentAggregateTest.php

@@ -8,7 +8,7 @@
 
 class EloquentAggregateTest extends DatabaseTestCase
 {
-    protected function defineDatabaseMigrationsAfterDatabaseRefreshed()
+    protected function afterRefreshingDatabase()
     {
         Schema::create('users', function (Blueprint $table) {
             $table->increments('id');

tests/Integration/Database/EloquentBelongsToManyTest.php

@@ -22,7 +22,7 @@ protected function tearDown(): void
         Carbon::setTestNow(null);
     }
 
-    protected function defineDatabaseMigrationsAfterDatabaseRefreshed()
+    protected function afterRefreshingDatabase()
     {
         Schema::create('users', function (Blueprint $table) {
             $table->increments('id');

tests/Integration/Database/EloquentBelongsToTest.php

@@ -10,7 +10,7 @@
 
 class EloquentBelongsToTest extends DatabaseTestCase
 {
-    protected function defineDatabaseMigrationsAfterDatabaseRefreshed()
+    protected function afterRefreshingDatabase()
     {
         Schema::create('users', function (Blueprint $table) {
             $table->increments('id');

tests/Integration/Database/EloquentCollectionFreshTest.php

@@ -9,7 +9,7 @@
 
 class EloquentCollectionFreshTest extends DatabaseTestCase
 {
-    protected function defineDatabaseMigrationsAfterDatabaseRefreshed()
+    protected function afterRefreshingDatabase()
     {
         Schema::create('users', function (Blueprint $table) {
             $table->increments('id');

tests/Integration/Database/EloquentCollectionLoadCountTest.php

@@ -12,7 +12,7 @@
 
 class EloquentCollectionLoadCountTest extends DatabaseTestCase
 {
-    protected function defineDatabaseMigrationsAfterDatabaseRefreshed()
+    protected function afterRefreshingDatabase()
     {
         Schema::create('posts', function (Blueprint $table) {
             $table->increments('id');