leverage native php 8.1 array_is_list (#41347)

Author: imanghafoori1

src/Illuminate/Collections/Arr.php

@@ -405,9 +405,7 @@ public static function hasAny($array, $keys)
      */
     public static function isAssoc(array $array)
     {
-        $keys = array_keys($array);
-
-        return array_keys($keys) !== $keys;
+        return ! array_is_list($array);
     }
 
     /**
@@ -420,7 +418,7 @@ public static function isAssoc(array $array)
      */
     public static function isList($array)
     {
-        return ! self::isAssoc($array);
+        return array_is_list($array);
     }
 
     /**
@@ -681,7 +679,7 @@ public static function sortRecursive($array, $options = SORT_REGULAR, $descendin
             }
         }
 
-        if (static::isAssoc($array)) {
+        if (! array_is_list($array)) {
             $descending
                     ? krsort($array, $options)
                     : ksort($array, $options);

src/Illuminate/Database/Eloquent/Relations/Relation.php

@@ -10,7 +10,6 @@
 use Illuminate\Database\Eloquent\ModelNotFoundException;
 use Illuminate\Database\MultipleRecordsFoundException;
 use Illuminate\Database\Query\Expression;
-use Illuminate\Support\Arr;
 use Illuminate\Support\Traits\ForwardsCalls;
 use Illuminate\Support\Traits\Macroable;
 
@@ -445,7 +444,7 @@ public static function morphMap(array $map = null, $merge = true)
      */
     protected static function buildMorphMapFromModels(array $models = null)
     {
-        if (is_null($models) || Arr::isAssoc($models)) {
+        if (is_null($models) || ! array_is_list($models)) {
             return $models;
         }
 

src/Illuminate/Redis/Connections/PhpRedisConnection.php

@@ -4,7 +4,6 @@
 
 use Closure;
 use Illuminate\Contracts\Redis\Connection as ConnectionContract;
-use Illuminate\Support\Arr;
 use Redis;
 use RedisException;
 
@@ -241,7 +240,7 @@ public function zadd($key, ...$dictionary)
      */
     public function zrangebyscore($key, $min, $max, $options = [])
     {
-        if (isset($options['limit']) && Arr::isAssoc($options['limit'])) {
+        if (isset($options['limit']) && ! array_is_list($options['limit'])) {
             $options['limit'] = [
                 $options['limit']['offset'],
                 $options['limit']['count'],
@@ -262,7 +261,7 @@ public function zrangebyscore($key, $min, $max, $options = [])
      */
     public function zrevrangebyscore($key, $min, $max, $options = [])
     {
-        if (isset($options['limit']) && Arr::isAssoc($options['limit'])) {
+        if (isset($options['limit']) && ! array_is_list($options['limit'])) {
             $options['limit'] = [
                 $options['limit']['offset'],
                 $options['limit']['count'],

src/Illuminate/Routing/RouteRegistrar.php

@@ -210,7 +210,7 @@ protected function compileAction($action)
         }
 
         if (is_array($action) &&
-            ! Arr::isAssoc($action) &&
+            array_is_list($action) &&
             Reflector::isCallable($action)) {
             if (strncmp($action[0], '\\', 1)) {
                 $action[0] = '\\'.$action[0];

src/Illuminate/Validation/NestedRules.php

@@ -40,7 +40,7 @@ public function compile($attribute, $value, $data = null)
             Arr::undot(Arr::wrap($data))
         );
 
-        if (is_array($rules) && Arr::isAssoc($rules)) {
+        if (is_array($rules) && ! array_is_list($rules)) {
             $nested = [];
 
             foreach ($rules as $key => $rule) {

tests/Support/SupportArrTest.php

@@ -452,6 +452,16 @@ public function testIsAssoc()
         $this->assertTrue(Arr::isAssoc([1 => 'a', 2 => 'b']));
         $this->assertFalse(Arr::isAssoc([0 => 'a', 1 => 'b']));
         $this->assertFalse(Arr::isAssoc(['a', 'b']));
+
+        $this->assertFalse(Arr::isAssoc([]));
+        $this->assertFalse(Arr::isAssoc([1, 2, 3]));
+        $this->assertFalse(Arr::isAssoc(['foo', 2, 3]));
+        $this->assertFalse(Arr::isAssoc([0 => 'foo', 'bar']));
+
+        $this->assertTrue(Arr::isAssoc([1 => 'foo', 'bar']));
+        $this->assertTrue(Arr::isAssoc([0 => 'foo', 'bar' => 'baz']));
+        $this->assertTrue(Arr::isAssoc([0 => 'foo', 2 => 'bar']));
+        $this->assertTrue(Arr::isAssoc(['foo' => 'bar', 'baz' => 'qux']));
     }
 
     public function testIsList()