[8.x] Bugfix passing errorlevel when command is run in background (#37479)

* Call schedule:finish with errorlevel

* Cmd with /v:on, escape expanded variable

Co-authored-by: Arjen van Oostrum <[email protected]>

Author: arjenvanoostrum

src/Illuminate/Console/Scheduling/CommandBuilder.php

@@ -52,7 +52,7 @@ protected function buildBackgroundCommand(Event $event)
         $finished = Application::formatCommandString('schedule:finish').' "'.$event->mutexName().'"';
 
         if (windows_os()) {
-            return 'start /b cmd /c "('.$event->command.' & '.$finished.' "%errorlevel%")'.$redirect.$output.' 2>&1"';
+            return 'start /b cmd /v:on /c "('.$event->command.' & '.$finished.' ^!ERRORLEVEL^!)'.$redirect.$output.' 2>&1"';
         }
 
         return $this->ensureCorrectUser($event,

tests/Console/Scheduling/EventTest.php

@@ -61,7 +61,7 @@ public function testBuildCommandInBackgroundUsingWindows()
 
         $scheduleId = '"framework'.DIRECTORY_SEPARATOR.'schedule-eeb46c93d45e928d62aaf684d727e213b7094822"';
 
-        $this->assertSame('start /b cmd /c "(php -i & "'.PHP_BINARY.'" artisan schedule:finish '.$scheduleId.' "%errorlevel%") > "NUL" 2>&1"', $event->buildCommand());
+        $this->assertSame('start /b cmd /v:on /c "(php -i & "'.PHP_BINARY.'" artisan schedule:finish '.$scheduleId.' ^!ERRORLEVEL^!) > "NUL" 2>&1"', $event->buildCommand());
     }
 
     public function testBuildCommandSendOutputTo()