Skip to content

Commit 256f497

Browse files
authored
[10.x] Skip convert empty string to null test (#48105)
* fix: typo in `testConvertsEmptyStringsToNull` * test: skip convert empty string to null
1 parent 81ae53f commit 256f497

File tree

1 file changed

+18
-1
lines changed

1 file changed

+18
-1
lines changed

tests/Foundation/Http/Middleware/ConvertEmptyStringsToNullTest.php

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,24 @@ public function testConvertsEmptyStringsToNull()
2121

2222
$middleware->handle($request, function (Request $request) {
2323
$this->assertSame('bar', $request->get('foo'));
24-
$this->assertNull($request->get('bar'));
24+
$this->assertNull($request->get('baz'));
25+
});
26+
}
27+
28+
public function testSkipConvertsEmptyStringsToNull()
29+
{
30+
$middleware = new ConvertEmptyStringsToNull;
31+
ConvertEmptyStringsToNull::skipWhen(fn ($request) => '' === $request->baz);
32+
$symfonyRequest = new SymfonyRequest([
33+
'foo' => 'bar',
34+
'baz' => '',
35+
]);
36+
$symfonyRequest->server->set('REQUEST_METHOD', 'GET');
37+
$request = Request::createFromBase($symfonyRequest);
38+
39+
$middleware->handle($request, function (Request $request) {
40+
$this->assertSame('bar', $request->get('foo'));
41+
$this->assertSame('', $request->get('baz'));
2542
});
2643
}
2744
}

0 commit comments

Comments
 (0)