[9.x] use Str::of method instead of re-calling Str class multiple… (#44425)

egyjs · taylorotwell · web-flow · commit 26dd9bd41283 · 2022-10-03T08:18:36.000-05:00
* [9.x] use `Str::of` method instead of re-calling `Str` class multiple times 

I believe this PR better than before, especially this is a Laravel core method

* Update ForeignIdColumnDefinition.php

Co-authored-by: Taylor Otwell &lt;taylor@laravel.com&gt;
diff --git a/src/Illuminate/Database/Schema/ForeignIdColumnDefinition.php b/src/Illuminate/Database/Schema/ForeignIdColumnDefinition.php
@@ -36,7 +36,7 @@ public function __construct(Blueprint $blueprint, $attributes = [])
      */
     public function constrained($table = null, $column = 'id')
     {
-        return $this->references($column)->on($table ?? Str::plural(Str::beforeLast($this->name, '_'.$column)));
+        return $this->references($column)->on($table ?? Str::of($this->name)->beforeLast('_'.$column)->plural());
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ public function __construct(Blueprint $blueprint, $attributes = [])`
`36`	`36`	`*/`
`37`	`37`	`public function constrained($table = null, $column = 'id')`
`38`	`38`	`{`
`39`		`- return $this->references($column)->on($table ?? Str::plural(Str::beforeLast($this->name, '_'.$column)));`
	`39`	`+ return $this->references($column)->on($table ?? Str::of($this->name)->beforeLast('_'.$column)->plural());`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`/**`