Disable Column Statistics for php artisan schema:dump on MariaDB (#43027)

BrandonSurowiec · web-flow · commit 33ef96e742e2 · 2022-07-01T13:43:43.000-07:00
Command fails on v10.x MariaDB.
diff --git a/src/Illuminate/Database/Schema/MySqlSchemaState.php b/src/Illuminate/Database/Schema/MySqlSchemaState.php
@@ -85,10 +85,10 @@ public function load($path)
      */
     protected function baseDumpCommand()
     {
-        $command = 'mysqldump '.$this->connectionString().' --no-tablespaces --skip-add-locks --skip-comments --skip-set-charset --tz-utc';
+        $command = 'mysqldump '.$this->connectionString().' --no-tablespaces --skip-add-locks --skip-comments --skip-set-charset --tz-utc --column-statistics=0';
 
         if (! $this->connection->isMaria()) {
-            $command .= ' --column-statistics=0 --set-gtid-purged=OFF';
+            $command .= ' --set-gtid-purged=OFF';
         }
 
         return $command.' "${:LARAVEL_LOAD_DATABASE}"';

Original file line number	Diff line number	Diff line change
`@@ -85,10 +85,10 @@ public function load($path)`
`85`	`85`	`*/`
`86`	`86`	`protected function baseDumpCommand()`
`87`	`87`	`{`
`88`		`- $command = 'mysqldump '.$this->connectionString().' --no-tablespaces --skip-add-locks --skip-comments --skip-set-charset --tz-utc';`
	`88`	`+ $command = 'mysqldump '.$this->connectionString().' --no-tablespaces --skip-add-locks --skip-comments --skip-set-charset --tz-utc --column-statistics=0';`
`89`	`89`
`90`	`90`	`if (! $this->connection->isMaria()) {`
`91`		`- $command .= ' --column-statistics=0 --set-gtid-purged=OFF';`
	`91`	`+ $command .= ' --set-gtid-purged=OFF';`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`return $command.' "${:LARAVEL_LOAD_DATABASE}"';`