[10.x] Facade Fake Awareness (#46188)

* Don't fake facades if they've already been faked

* Fix auto-imported FQNs

* Remove unused param

* fix test

* Update src/Illuminate/Support/Facades/Facade.php

* Update src/Illuminate/Support/Facades/Queue.php

* Update src/Illuminate/Support/Facades/Facade.php

* Update Facade.php

---------

Co-authored-by: Dries Vints <[email protected]>
Co-authored-by: Taylor Otwell <[email protected]>

Author: 3 people

src/Illuminate/Support/Facades/Bus.php

@@ -60,9 +60,11 @@ class Bus extends Facade
      */
     public static function fake($jobsToFake = [], BatchRepository $batchRepository = null)
     {
-        static::swap($fake = new BusFake(static::getFacadeRoot(), $jobsToFake, $batchRepository));
-
-        return $fake;
+        return tap(new BusFake(static::getFacadeRoot(), $jobsToFake, $batchRepository), function ($fake) {
+            if (! static::isFake()) {
+                static::swap($fake);
+            }
+        });
     }
 
     /**

src/Illuminate/Support/Facades/Event.php

@@ -47,12 +47,14 @@ class Event extends Facade
      */
     public static function fake($eventsToFake = [])
     {
-        static::swap($fake = new EventFake(static::getFacadeRoot(), $eventsToFake));
+        return tap(new EventFake(static::getFacadeRoot(), $eventsToFake), function ($fake) {
+            if (! static::isFake()) {
+                static::swap($fake);
 
-        Model::setEventDispatcher($fake);
-        Cache::refreshEventDispatcher();
-
-        return $fake;
+                Model::setEventDispatcher($fake);
+                Cache::refreshEventDispatcher();
+            }
+        });
     }
 
     /**

src/Illuminate/Support/Facades/Facade.php

@@ -7,6 +7,7 @@
 use Illuminate\Support\Arr;
 use Illuminate\Support\Js;
 use Illuminate\Support\Str;
+use Illuminate\Support\Testing\Fakes\Fake;
 use Mockery;
 use Mockery\LegacyMockInterface;
 use RuntimeException;
@@ -183,6 +184,19 @@ public static function swap($instance)
         }
     }
 
+    /**
+     * Determines whether a "fake" has been set as the facade instance.
+     *
+     * @return bool
+     */
+    protected static function isFake()
+    {
+        $name = static::getFacadeAccessor();
+
+        return isset(static::$resolvedInstance[$name]) &&
+               static::$resolvedInstance[$name] instanceof Fake;
+    }
+
     /**
      * Get the root object behind the facade.
      *

src/Illuminate/Support/Facades/Mail.php

@@ -65,9 +65,11 @@ class Mail extends Facade
      */
     public static function fake()
     {
-        static::swap($fake = new MailFake(static::getFacadeRoot()));
-
-        return $fake;
+        return tap(new MailFake(static::getFacadeRoot()), function ($fake) {
+            if (! static::isFake()) {
+                static::swap($fake);
+            }
+        });
     }
 
     /**

src/Illuminate/Support/Facades/Notification.php

@@ -49,9 +49,11 @@ class Notification extends Facade
      */
     public static function fake()
     {
-        static::swap($fake = new NotificationFake);
-
-        return $fake;
+        return tap(new NotificationFake(), function ($fake) {
+            if (! static::isFake()) {
+                static::swap($fake);
+            }
+        });
     }
 
     /**

src/Illuminate/Support/Facades/Queue.php

@@ -76,9 +76,11 @@ public static function popUsing($workerName, $callback)
      */
     public static function fake($jobsToFake = [])
     {
-        static::swap($fake = new QueueFake(static::getFacadeApplication(), $jobsToFake, static::getFacadeRoot()));
-
-        return $fake;
+        tap(new QueueFake(static::getFacadeApplication(), $jobsToFake, static::getFacadeRoot()), function ($fake) {
+            if (! static::isFake()) {
+                static::swap($fake);
+            }
+        });
     }
 
     /**

src/Illuminate/Support/Testing/Fakes/BusFake.php

@@ -11,7 +11,7 @@
 use Illuminate\Support\Traits\ReflectsClosures;
 use PHPUnit\Framework\Assert as PHPUnit;
 
-class BusFake implements QueueingDispatcher
+class BusFake implements Fake, QueueingDispatcher
 {
     use ReflectsClosures;
 

src/Illuminate/Support/Testing/Fakes/EventFake.php

@@ -11,7 +11,7 @@
 use PHPUnit\Framework\Assert as PHPUnit;
 use ReflectionFunction;
 
-class EventFake implements Dispatcher
+class EventFake implements Dispatcher, Fake
 {
     use ForwardsCalls, ReflectsClosures;
 

src/Illuminate/Support/Testing/Fakes/Fake.php

@@ -0,0 +1,8 @@
+<?php
+
+namespace Illuminate\Support\Testing\Fakes;
+
+interface Fake
+{
+    //
+}

src/Illuminate/Support/Testing/Fakes/MailFake.php

@@ -13,7 +13,7 @@
 use Illuminate\Support\Traits\ReflectsClosures;
 use PHPUnit\Framework\Assert as PHPUnit;
 
-class MailFake implements Factory, Mailer, MailQueue
+class MailFake implements Factory, Fake, Mailer, MailQueue
 {
     use ForwardsCalls, ReflectsClosures;