Add ability to supply HTTP client methods with Arrayable instances

Author: stevebauman

src/Illuminate/Http/Client/PendingRequest.php

@@ -581,7 +581,7 @@ public function head(string $url, $query = null)
      * @param  array  $data
      * @return \Illuminate\Http\Client\Response
      */
-    public function post(string $url, array $data = [])
+    public function post(string $url, $data = [])
     {
         return $this->send('POST', $url, [
             $this->bodyFormat => $data,
@@ -661,24 +661,10 @@ public function pool(callable $callback)
      */
     public function send(string $method, string $url, array $options = [])
     {
+        $options = $this->parseHttpOptions($options);
+        
         $url = ltrim(rtrim($this->baseUrl, '/').'/'.ltrim($url, '/'), '/');
 
-        if (isset($options[$this->bodyFormat])) {
-            if ($this->bodyFormat === 'multipart') {
-                $options[$this->bodyFormat] = $this->parseMultipartBodyFormat($options[$this->bodyFormat]);
-            } elseif ($this->bodyFormat === 'body') {
-                $options[$this->bodyFormat] = $this->pendingBody;
-            }
-
-            if (is_array($options[$this->bodyFormat])) {
-                $options[$this->bodyFormat] = array_merge(
-                    $options[$this->bodyFormat], $this->pendingFiles
-                );
-            }
-        } else {
-            $options[$this->bodyFormat] = $this->pendingBody;
-        }
-
         [$this->pendingBody, $this->pendingFiles] = [null, []];
 
         if ($this->async) {
@@ -704,6 +690,33 @@ public function send(string $method, string $url, array $options = [])
         }, $this->retryDelay ?? 100, $this->retryWhenCallback);
     }
 
+     /**
+     * Parse the HTTP options.
+     *
+     * @param  array  $options
+     * @return array|array[]
+     */
+    protected function parseHttpOptions(array $options)
+    {
+        if (isset($options[$this->bodyFormat])) {
+            if ($this->bodyFormat === 'multipart') {
+                $options[$this->bodyFormat] = $this->parseMultipartBodyFormat($options[$this->bodyFormat]);
+            } elseif ($this->bodyFormat === 'body') {
+                $options[$this->bodyFormat] = $this->pendingBody;
+            }
+
+            if (is_array($options[$this->bodyFormat])) {
+                $options[$this->bodyFormat] = array_merge(
+                    $options[$this->bodyFormat], $this->pendingFiles
+                );
+            }
+        } else {
+            $options[$this->bodyFormat] = $this->pendingBody;
+        }
+
+        return collect($options)->toArray();
+    }
+
     /**
      * Parse multi-part form data.
      *

tests/Http/HttpClientTest.php

@@ -15,6 +15,7 @@
 use Illuminate\Http\Client\Response;
 use Illuminate\Http\Client\ResponseSequence;
 use Illuminate\Support\Collection;
+use Illuminate\Support\Fluent;
 use Illuminate\Support\Str;
 use Mockery as m;
 use OutOfBoundsException;
@@ -180,6 +181,22 @@ public function testCanSendFormData()
         });
     }
 
+    public function testCanSendArrayableFormData()
+    {
+        $this->factory->fake();
+
+        $this->factory->asForm()->post('http://foo.com/form', new Fluent([
+            'name' => 'Taylor',
+            'title' => 'Laravel Developer',
+        ]));
+
+        $this->factory->assertSent(function (Request $request) {
+            return $request->url() === 'http://foo.com/form' &&
+                   $request->hasHeader('Content-Type', 'application/x-www-form-urlencoded') &&
+                   $request['name'] === 'Taylor';
+        });
+    }
+
     public function testSpecificRequestIsNotBeingSent()
     {
         $this->factory->fake();
@@ -435,6 +452,18 @@ public function testGetWithArrayQueryParam()
         });
     }
 
+    public function testGetWithArrayableQueryParam()
+    {
+        $this->factory->fake();
+
+        $this->factory->get('http://foo.com/get', new Fluent(['foo' => 'bar']));
+
+        $this->factory->assertSent(function (Request $request) {
+            return $request->url() === 'http://foo.com/get?foo=bar'
+                && $request['foo'] === 'bar';
+        });
+    }
+
     public function testGetWithStringQueryParam()
     {
         $this->factory->fake();