Replace strpos with str_contains and str_starts_with (#40353)

Author: lucasmichot

src/Illuminate/Auth/Access/Gate.php

@@ -808,7 +808,7 @@ protected function callPolicyMethod($policy, $method, $user, array $arguments)
      */
     protected function formatAbilityToMethod($ability)
     {
-        return strpos($ability, '-') !== false ? Str::camel($ability) : $ability;
+        return str_contains($ability, '-') ? Str::camel($ability) : $ability;
     }
 
     /**

src/Illuminate/Collections/Arr.php

@@ -314,7 +314,7 @@ public static function get($array, $key, $default = null)
             return $array[$key];
         }
 
-        if (strpos($key, '.') === false) {
+        if (! str_contains($key, '.')) {
             return $array[$key] ?? value($default);
         }
 

src/Illuminate/Cookie/CookieValuePrefix.php

@@ -37,7 +37,7 @@ public static function remove($cookieValue)
      */
     public static function validate($cookieName, $cookieValue, $key)
     {
-        $hasValidPrefix = strpos($cookieValue, static::create($cookieName, $key)) === 0;
+        $hasValidPrefix = str_starts_with($cookieValue, static::create($cookieName, $key));
 
         return $hasValidPrefix ? static::remove($cookieValue) : null;
     }

src/Illuminate/Database/Console/Seeds/SeedCommand.php

@@ -93,7 +93,7 @@ protected function getSeeder()
     {
         $class = $this->input->getArgument('class') ?? $this->input->getOption('class');
 
-        if (strpos($class, '\\') === false) {
+        if (! str_contains($class, '\\')) {
             $class = 'Database\\Seeders\\'.$class;
         }
 

src/Illuminate/Database/Eloquent/Builder.php

@@ -638,7 +638,7 @@ public function eagerLoadRelations(array $models)
             // For nested eager loads we'll skip loading them here and they will be set as an
             // eager load on the query to retrieve the relation so that they will be eager
             // loaded on that query, because that is where they get hydrated as models.
-            if (strpos($name, '.') === false) {
+            if (! str_contains($name, '.')) {
                 $models = $this->eagerLoadRelation($models, $name, $constraints);
             }
         }

src/Illuminate/Database/Eloquent/Concerns/GuardsAttributes.php

@@ -187,7 +187,7 @@ public function isFillable($key)
         }
 
         return empty($this->getFillable()) &&
-            strpos($key, '.') === false &&
+            ! str_contains($key, '.') &&
             ! Str::startsWith($key, '_');
     }
 

src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php

@@ -1554,7 +1554,7 @@ protected function resolveCasterClass($key)
 
         $arguments = [];
 
-        if (is_string($castType) && strpos($castType, ':') !== false) {
+        if (is_string($castType) && str_contains($castType, ':')) {
             $segments = explode(':', $castType, 2);
 
             $castType = $segments[0];
@@ -1580,7 +1580,7 @@ protected function resolveCasterClass($key)
      */
     protected function parseCasterClass($class)
     {
-        return strpos($class, ':') === false
+        return ! str_contains($class, ':')
             ? $class
             : explode(':', $class, 2)[0];
     }

src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php

@@ -30,7 +30,7 @@ trait QueriesRelationships
     public function has($relation, $operator = '>=', $count = 1, $boolean = 'and', Closure $callback = null)
     {
         if (is_string($relation)) {
-            if (strpos($relation, '.') !== false) {
+            if (str_contains($relation, '.')) {
                 return $this->hasNested($relation, $operator, $count, $boolean, $callback);
             }
 

src/Illuminate/Database/Eloquent/Relations/BelongsToMany.php

@@ -1059,7 +1059,7 @@ protected function migratePivotAttributes(Model $model)
             // To get the pivots attributes we will just take any of the attributes which
             // begin with "pivot_" and add those to this arrays, as well as unsetting
             // them from the parent's models since they exist in a different table.
-            if (strpos($key, 'pivot_') === 0) {
+            if (str_starts_with($key, 'pivot_')) {
                 $values[substr($key, 6)] = $value;
 
                 unset($model->$key);

src/Illuminate/Database/MySqlConnection.php

@@ -20,7 +20,7 @@ class MySqlConnection extends Connection
      */
     public function isMaria()
     {
-        return strpos($this->getPdo()->getAttribute(PDO::ATTR_SERVER_VERSION), 'MariaDB') !== false;
+        return str_contains($this->getPdo()->getAttribute(PDO::ATTR_SERVER_VERSION), 'MariaDB');
     }
 
     /**