Enforce consistancy when calling a function by its name. (#40788)

Author: lucasmichot

src/Illuminate/Container/Container.php

@@ -609,7 +609,7 @@ protected function rebound($abstract)
         $instance = $this->make($abstract);
 
         foreach ($this->getReboundCallbacks($abstract) as $callback) {
-            call_user_func($callback, $this, $instance);
+            $callback($this, $instance);
         }
     }
 

src/Illuminate/Database/DatabaseTransactionRecord.php

@@ -57,7 +57,7 @@ public function addCallback($callback)
     public function executeCallbacks()
     {
         foreach ($this->callbacks as $callback) {
-            call_user_func($callback);
+            $callback();
         }
     }
 

src/Illuminate/Database/DatabaseTransactionsManager.php

@@ -81,7 +81,7 @@ public function addCallback($callback)
             return $current->addCallback($callback);
         }
 
-        call_user_func($callback);
+        $callback();
     }
 
     /**

src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php

@@ -1011,7 +1011,7 @@ protected function setAttributeMarkedMutatedAttributeValue($key, $value)
         $this->attributes = array_merge(
             $this->attributes,
             $this->normalizeCastClassResponse(
-                $key, call_user_func($callback, $value, $this->attributes)
+                $key, $callback($value, $this->attributes)
             )
         );
 
@@ -1641,7 +1641,7 @@ protected function mergeAttributesFromAttributeCasts()
             $this->attributes = array_merge(
                 $this->attributes,
                 $this->normalizeCastClassResponse(
-                    $key, call_user_func($callback, $value, $this->attributes)
+                    $key, $callback($value, $this->attributes)
                 )
             );
         }

src/Illuminate/Database/Query/Builder.php

@@ -1515,7 +1515,7 @@ protected function addDateBasedWhere($type, $column, $operator, $value, $boolean
      */
     public function whereNested(Closure $callback, $boolean = 'and')
     {
-        call_user_func($callback, $query = $this->forNestedWhere());
+        $callback($query = $this->forNestedWhere());
 
         return $this->addNestedWhereQuery($query, $boolean);
     }
@@ -1566,7 +1566,7 @@ protected function whereSub($column, $operator, Closure $callback, $boolean)
         // Once we have the query instance we can simply execute it so it can add all
         // of the sub-select's conditions to itself, and then we can cache it off
         // in the array of where clauses for the "main" parent query instance.
-        call_user_func($callback, $query = $this->forSubQuery());
+        $callback($query = $this->forSubQuery());
 
         $this->wheres[] = compact(
             'type', 'column', 'operator', 'query', 'boolean'
@@ -1592,7 +1592,7 @@ public function whereExists(Closure $callback, $boolean = 'and', $not = false)
         // Similar to the sub-select clause, we will create a new query instance so
         // the developer may cleanly specify the entire exists query and we will
         // compile the whole thing in the grammar and insert it into the SQL.
-        call_user_func($callback, $query);
+        $callback($query);
 
         return $this->addWhereExistsQuery($query, $boolean, $not);
     }
@@ -1991,7 +1991,7 @@ public function orHaving($column, $operator = null, $value = null)
      */
     public function havingNested(Closure $callback, $boolean = 'and')
     {
-        call_user_func($callback, $query = $this->forNestedWhere());
+        $callback($query = $this->forNestedWhere());
 
         return $this->addNestedHavingQuery($query, $boolean);
     }
@@ -2367,7 +2367,7 @@ protected function removeExistingOrdersFor($column)
     public function union($query, $all = false)
     {
         if ($query instanceof Closure) {
-            call_user_func($query, $query = $this->newQuery());
+            $query($query = $this->newQuery());
         }
 
         $this->unions[] = compact('query', 'all');

src/Illuminate/Queue/Middleware/RateLimited.php

@@ -56,7 +56,7 @@ public function handle($job, $next)
             return $next($job);
         }
 
-        $limiterResponse = call_user_func($limiter, $job);
+        $limiterResponse = $limiter($job);
 
         if ($limiterResponse instanceof Unlimited) {
             return $next($job);

src/Illuminate/Queue/Queue.php

@@ -282,9 +282,7 @@ protected function withCreatePayloadHooks($queue, array $payload)
     {
         if (! empty(static::$createPayloadCallbacks)) {
             foreach (static::$createPayloadCallbacks as $callback) {
-                $payload = array_merge($payload, call_user_func(
-                    $callback, $this->getConnectionName(), $queue, $payload
-                ));
+                $payload = array_merge($payload, $callback($this->getConnectionName(), $queue, $payload));
             }
         }
 

src/Illuminate/Redis/Connections/PredisConnection.php

@@ -44,7 +44,7 @@ public function createSubscription($channels, Closure $callback, $method = 'subs
 
         foreach ($loop as $message) {
             if ($message->kind === 'message' || $message->kind === 'pmessage') {
-                call_user_func($callback, $message->payload, $message->channel);
+                $callback($message->payload, $message->channel);
             }
         }
 

src/Illuminate/Routing/Middleware/ThrottleRequests.php

@@ -81,7 +81,7 @@ public function handle($request, Closure $next, $maxAttempts = 60, $decayMinutes
      */
     protected function handleRequestUsingNamedLimiter($request, Closure $next, $limiterName, Closure $limiter)
     {
-        $limiterResponse = call_user_func($limiter, $request);
+        $limiterResponse = $limiter($request);
 
         if ($limiterResponse instanceof Response) {
             return $limiterResponse;

src/Illuminate/Support/Stringable.php

@@ -444,7 +444,7 @@ public function parseCallback($default = null)
      */
     public function pipe(callable $callback)
     {
-        return new static(call_user_func($callback, $this));
+        return new static($callback($this));
     }
 
     /**