[10.x] Passthru missing methods on EventFake & MailFake for macro accessibility (#45988)

* Allow mailer macros to be called when faked

* Allow event macros to be called when faked

* Add test

* Revert breaking mail fake changes

* Rename test

* Add support for method passthru on `MailFake`

* CS fixes

* formatting

---------

Co-authored-by: Taylor Otwell <[email protected]>

Author: stevebauman

src/Illuminate/Support/Facades/Mail.php

@@ -65,7 +65,7 @@ class Mail extends Facade
      */
     public static function fake()
     {
-        static::swap($fake = new MailFake);
+        static::swap($fake = new MailFake(static::getFacadeRoot()));
 
         return $fake;
     }

src/Illuminate/Support/Testing/Fakes/EventFake.php

@@ -6,13 +6,14 @@
 use Illuminate\Contracts\Events\Dispatcher;
 use Illuminate\Support\Arr;
 use Illuminate\Support\Str;
+use Illuminate\Support\Traits\ForwardsCalls;
 use Illuminate\Support\Traits\ReflectsClosures;
 use PHPUnit\Framework\Assert as PHPUnit;
 use ReflectionFunction;
 
 class EventFake implements Dispatcher
 {
-    use ReflectsClosures;
+    use ForwardsCalls, ReflectsClosures;
 
     /**
      * The original event dispatcher.
@@ -377,4 +378,16 @@ public function until($event, $payload = [])
     {
         return $this->dispatch($event, $payload, true);
     }
+
+    /**
+     * Handle dynamic method calls to the dispatcher.
+     *
+     * @param  string  $method
+     * @param  array  $parameters
+     * @return mixed
+     */
+    public function __call($method, $parameters)
+    {
+        return $this->forwardCallTo($this->dispatcher, $method, $parameters);
+    }
 }

src/Illuminate/Support/Testing/Fakes/MailFake.php

@@ -8,12 +8,20 @@
 use Illuminate\Contracts\Mail\Mailer;
 use Illuminate\Contracts\Mail\MailQueue;
 use Illuminate\Contracts\Queue\ShouldQueue;
+use Illuminate\Support\Traits\ForwardsCalls;
 use Illuminate\Support\Traits\ReflectsClosures;
 use PHPUnit\Framework\Assert as PHPUnit;
 
 class MailFake implements Factory, Mailer, MailQueue
 {
-    use ReflectsClosures;
+    use ForwardsCalls, ReflectsClosures;
+
+    /**
+     * The mailer instance.
+     *
+     * @var Mailer
+     */
+    protected $mailer;
 
     /**
      * The mailer currently being used to send a message.
@@ -36,6 +44,17 @@ class MailFake implements Factory, Mailer, MailQueue
      */
     protected $queuedMailables = [];
 
+    /**
+     * Create a new mail fake.
+     *
+     * @param  Mailer  $mailer
+     * @return void
+     */
+    public function __construct(Mailer $mailer)
+    {
+        $this->mailer = $mailer;
+    }
+
     /**
      * Assert if a mailable was sent based on a truth-test callback.
      *
@@ -431,4 +450,16 @@ public function forgetMailers()
 
         return $this;
     }
+
+    /**
+     * Handle dynamic method calls to the mailer.
+     *
+     * @param  string  $method
+     * @param  array  $parameters
+     * @return mixed
+     */
+    public function __call($method, $parameters)
+    {
+        return $this->forwardCallTo($this->mailer, $method, $parameters);
+    }
 }

tests/Integration/Events/EventFakeTest.php

@@ -151,7 +151,7 @@ public function testAssertListening()
 
         Post::observe(new PostObserver);
 
-        ($post = new Post)->save();
+        (new Post)->save();
 
         Event::assertListening('event', 'listener');
         Event::assertListening('event', PostEventSubscriber::class);
@@ -163,6 +163,13 @@ public function testAssertListening()
         Event::assertListening('eloquent.saving: '.Post::class, PostObserver::class.'@saving');
         Event::assertListening('eloquent.saving: '.Post::class, [PostObserver::class, 'saving']);
     }
+
+    public function testMissingMethodsAreForwarded()
+    {
+        Event::macro('foo', fn () => 'bar');
+
+        $this->assertEquals('bar', Event::fake()->foo());
+    }
 }
 
 class Post extends Model

tests/Support/SupportTestingMailFakeTest.php

@@ -5,12 +5,19 @@
 use Illuminate\Contracts\Queue\ShouldQueue;
 use Illuminate\Contracts\Translation\HasLocalePreference;
 use Illuminate\Mail\Mailable;
+use Illuminate\Mail\Mailer;
 use Illuminate\Support\Testing\Fakes\MailFake;
+use Mockery as m;
 use PHPUnit\Framework\ExpectationFailedException;
 use PHPUnit\Framework\TestCase;
 
 class SupportTestingMailFakeTest extends TestCase
 {
+    /**
+     * @var \Mockery
+     */
+    private $mailer;
+
     /**
      * @var \Illuminate\Support\Testing\Fakes\MailFake
      */
@@ -24,7 +31,8 @@ class SupportTestingMailFakeTest extends TestCase
     protected function setUp(): void
     {
         parent::setUp();
-        $this->fake = new MailFake;
+        $this->mailer = m::mock(Mailer::class);
+        $this->fake = new MailFake($this->mailer);
         $this->mailable = new MailableStub;
     }
 
@@ -213,6 +221,13 @@ public function testAssertSentWithClosure()
             return $mail->hasTo($user);
         });
     }
+
+    public function testMissingMethodsAreForwarded()
+    {
+        $this->mailer->shouldReceive('foo')->andReturn('bar');
+
+        $this->assertEquals('bar', $this->fake->foo());
+    }
 }
 
 class MailableStub extends Mailable