Enforce stricter assertions. (#41165)

Author: lucasmichot

tests/Cache/CacheManagerTest.php

@@ -56,7 +56,7 @@ public function testCustomDriverOverridesInternalDrivers()
 
         $driver = $cacheManager->store('my_store');
 
-        $this->assertEquals('mm(u_u)mm', $driver->flag);
+        $this->assertSame('mm(u_u)mm', $driver->flag);
     }
 
     public function testItMakesRepositoryWhenContainerHasNoDispatcher()

tests/Cache/CacheRateLimiterTest.php

@@ -105,7 +105,7 @@ public function testAttemptsCallbackReturnsCallbackReturn()
 
         $rateLimiter = new RateLimiter($cache);
 
-        $this->assertEquals('foo', $rateLimiter->attempt('key', 1, function () {
+        $this->assertSame('foo', $rateLimiter->attempt('key', 1, function () {
             return 'foo';
         }, 1));
     }

tests/Console/ConsoleEventSchedulerTest.php

@@ -124,15 +124,15 @@ public function testItUsesCommandDescriptionAsEventDescription()
     {
         $schedule = $this->schedule;
         $event = $schedule->command(ConsoleCommandStub::class);
-        $this->assertEquals('This is a description about the command', $event->description);
+        $this->assertSame('This is a description about the command', $event->description);
     }
 
     public function testItShouldBePossibleToOverwriteTheDescription()
     {
         $schedule = $this->schedule;
         $event = $schedule->command(ConsoleCommandStub::class)
             ->description('This is an alternative description');
-        $this->assertEquals('This is an alternative description', $event->description);
+        $this->assertSame('This is an alternative description', $event->description);
     }
 
     public function testCallCreatesNewJobWithTimezone()

tests/Cookie/CookieTest.php

@@ -120,10 +120,10 @@ public function testExpire()
         $cookieJar->expire('foobar', '/path', '/domain');
 
         $cookie = $cookieJar->queued('foobar');
-        $this->assertEquals('foobar', $cookie->getName());
+        $this->assertSame('foobar', $cookie->getName());
         $this->assertEquals(null, $cookie->getValue());
-        $this->assertEquals('/path', $cookie->getPath());
-        $this->assertEquals('/domain', $cookie->getDomain());
+        $this->assertSame('/path', $cookie->getPath());
+        $this->assertSame('/domain', $cookie->getDomain());
         $this->assertTrue($cookie->getExpiresTime() < time());
         $this->assertCount(1, $cookieJar->getQueuedCookies());
     }

tests/Database/DatabaseEloquentBelongsToManySyncReturnValueTypeTest.php

@@ -90,7 +90,7 @@ public function testSyncReturnValueType()
         });
 
         $user->articles->each(function (BelongsToManySyncTestTestArticle $article) {
-            $this->assertEquals('0', $article->pivot->visible);
+            $this->assertSame('0', (string) $article->pivot->visible);
         });
     }
 
@@ -108,7 +108,7 @@ public function testSyncWithPivotDefaultsReturnValueType()
         });
 
         $user->articles->each(function (BelongsToManySyncTestTestArticle $article) {
-            $this->assertEquals('1', $article->pivot->visible);
+            $this->assertSame('1', (string) $article->pivot->visible);
         });
     }
 

tests/Database/DatabaseEloquentBelongsToManySyncTouchesParentTest.php

@@ -89,7 +89,7 @@ public function testSyncWithDetachedValuesShouldTouch()
         Carbon::setTestNow('2021-07-20 19:13:14');
         $result = $article->users()->sync([1, 2]);
         $this->assertCount(1, collect($result['detached']));
-        $this->assertSame('3', collect($result['detached'])->first());
+        $this->assertSame('3', (string) collect($result['detached'])->first());
 
         $article->refresh();
         $this->assertSame('2021-07-20 19:13:14', $article->updated_at->format('Y-m-d H:i:s'));

tests/Database/DatabaseEloquentBelongsToTest.php

@@ -127,7 +127,7 @@ public function __toString()
 
         $this->assertEquals(1, $models[0]->foo->getAttribute('id'));
         $this->assertEquals(2, $models[1]->foo->getAttribute('id'));
-        $this->assertEquals('3', $models[2]->foo->getAttribute('id'));
+        $this->assertSame('3', (string) $models[2]->foo->getAttribute('id'));
     }
 
     public function testAssociateMethodSetsForeignKeyOnModel()

tests/Database/DatabaseEloquentHasOneTest.php

@@ -183,7 +183,7 @@ public function __toString()
         $this->assertEquals(1, $models[0]->foo->foreign_key);
         $this->assertEquals(2, $models[1]->foo->foreign_key);
         $this->assertNull($models[2]->foo);
-        $this->assertEquals('4', $models[3]->foo->foreign_key);
+        $this->assertSame('4', (string) $models[3]->foo->foreign_key);
     }
 
     public function testRelationCountQueryCanBeBuilt()

tests/Database/DatabaseEloquentStrictMorphsTest.php

@@ -34,7 +34,7 @@ public function testStrictModeDoesNotThrowExceptionWhenMorphMap()
         ]);
 
         $morphName = $model->getMorphClass();
-        $this->assertEquals('test', $morphName);
+        $this->assertSame('test', $morphName);
     }
 
     public function testMapsCanBeEnforcedInOneMethod()
@@ -48,7 +48,7 @@ public function testMapsCanBeEnforcedInOneMethod()
         ]);
 
         $morphName = $model->getMorphClass();
-        $this->assertEquals('test', $morphName);
+        $this->assertSame('test', $morphName);
     }
 
     protected function tearDown(): void

tests/Foundation/FoundationFormRequestTest.php

@@ -135,7 +135,7 @@ public function testValidatedMethodReturnsOnlyRequestedValidatedData()
 
         $request->validateResolved();
 
-        $this->assertEquals('specified', $request->validated('name'));
+        $this->assertSame('specified', $request->validated('name'));
     }
 
     public function testValidatedMethodReturnsOnlyRequestedNestedValidatedData()
@@ -146,7 +146,7 @@ public function testValidatedMethodReturnsOnlyRequestedNestedValidatedData()
 
         $request->validateResolved();
 
-        $this->assertEquals('bar', $request->validated('nested.foo'));
+        $this->assertSame('bar', $request->validated('nested.foo'));
     }
 
     /**