[10.x] Small test fixes (#47369)

* Fix test name typos

* Fix test names and remove unused variables

* Remove unused method and import

Author: stevebauman

tests/Validation/ValidationEnumRuleTest.php

@@ -15,7 +15,7 @@
 
 class ValidationEnumRuleTest extends TestCase
 {
-    public function testvalidationPassesWhenPassingCorrectEnum()
+    public function testValidationPassesWhenPassingCorrectEnum()
     {
         $v = new Validator(
             resolve('translator'),
@@ -32,7 +32,7 @@ public function testvalidationPassesWhenPassingCorrectEnum()
         $this->assertFalse($v->fails());
     }
 
-    public function testvalidationPassesWhenPassingInstanceOfEnum()
+    public function testValidationPassesWhenPassingInstanceOfEnum()
     {
         $v = new Validator(
             resolve('translator'),
@@ -47,7 +47,7 @@ public function testvalidationPassesWhenPassingInstanceOfEnum()
         $this->assertFalse($v->fails());
     }
 
-    public function testvalidationPassesWhenPassingInstanceOfPureEnum()
+    public function testValidationPassesWhenPassingInstanceOfPureEnum()
     {
         $v = new Validator(
             resolve('translator'),

tests/Validation/ValidationExcludeIfTest.php

@@ -10,7 +10,7 @@
 
 class ValidationExcludeIfTest extends TestCase
 {
-    public function testItClousureReturnsFormatsAStringVersionOfTheRule()
+    public function testItReturnsStringVersionOfRuleWhenCast()
     {
         $rule = new ExcludeIf(function () {
             return true;
@@ -33,7 +33,7 @@ public function testItClousureReturnsFormatsAStringVersionOfTheRule()
         $this->assertSame('', (string) $rule);
     }
 
-    public function testItOnlyCallableAndBooleanAreAcceptableArgumentsOfTheRule()
+    public function testItValidatesCallableAndBooleanAreAcceptableArguments()
     {
         new ExcludeIf(false);
         new ExcludeIf(true);
@@ -49,11 +49,11 @@ public function testItOnlyCallableAndBooleanAreAcceptableArgumentsOfTheRule()
         }
     }
 
-    public function testItReturnedRuleIsNotSerializable()
+    public function testItThrowsExceptionIfRuleIsNotSerializable()
     {
         $this->expectException(Exception::class);
 
-        $rule = serialize(new ExcludeIf(function () {
+        serialize(new ExcludeIf(function () {
             return true;
         }));
     }

tests/Validation/ValidationForEachTest.php

@@ -6,7 +6,6 @@
 use Illuminate\Translation\Translator;
 use Illuminate\Validation\Rule;
 use Illuminate\Validation\Validator;
-use Mockery as m;
 use PHPUnit\Framework\TestCase;
 
 class ValidationForEachTest extends TestCase
@@ -320,11 +319,6 @@ public function testConditionalRulesCanBeAddedToForEachWithObject()
         ], $v->getMessageBag()->toArray());
     }
 
-    protected function getTranslator()
-    {
-        return m::mock(TranslatorContract::class);
-    }
-
     public function getIlluminateArrayTranslator()
     {
         return new Translator(

tests/Validation/ValidationProhibitedIfTest.php

@@ -10,7 +10,7 @@
 
 class ValidationProhibitedIfTest extends TestCase
 {
-    public function testItClousureReturnsFormatsAStringVersionOfTheRule()
+    public function testItReturnsStringVersionOfRuleWhenCast()
     {
         $rule = new ProhibitedIf(function () {
             return true;
@@ -33,27 +33,27 @@ public function testItClousureReturnsFormatsAStringVersionOfTheRule()
         $this->assertSame('', (string) $rule);
     }
 
-    public function testItOnlyCallableAndBooleanAreAcceptableArgumentsOfTheRule()
+    public function testItValidatesCallableAndBooleanAreAcceptableArguments()
     {
-        $rule = new ProhibitedIf(false);
-
-        $rule = new ProhibitedIf(true);
+        new ProhibitedIf(false);
+        new ProhibitedIf(true);
+        new ProhibitedIf(fn () => true);
 
         foreach ([1, 1.1, 'phpinfo', new stdClass] as $condition) {
             try {
-                $rule = new ProhibitedIf($condition);
+                new ProhibitedIf($condition);
                 $this->fail('The ProhibitedIf constructor must not accept '.gettype($condition));
             } catch (InvalidArgumentException $exception) {
                 $this->assertEquals('The provided condition must be a callable or boolean.', $exception->getMessage());
             }
         }
     }
 
-    public function testItReturnedRuleIsNotSerializable()
+    public function testItThrowsExceptionIfRuleIsNotSerializable()
     {
         $this->expectException(Exception::class);
 
-        $rule = serialize(new ProhibitedIf(function () {
+        serialize(new ProhibitedIf(function () {
             return true;
         }));
     }