[13.x] Do not allow new model instances to be created during boot (#55685)

* Add failing test

* Only mark a model class as booted after the boot process has been completed

* Mark a model class as booting as soon as the boot process starts

- A model class is removed from the `booting` array as soon as the boot process has completed.

* Throw an exception if `bootIfNotBooted` is called while booting

- This infers that something in the boot process expected the boot to already be finished.
- If we just ignore the call then the model class would be in an inconsistent state for whichever code called it.

* formatting

* formatting

---------

Co-authored-by: Taylor Otwell <[email protected]>

Author: willrowe

src/Illuminate/Database/Eloquent/Model.php

@@ -4,6 +4,7 @@
 
 use ArrayAccess;
 use Closure;
+use Exception;
 use Illuminate\Contracts\Broadcasting\HasBroadcastChannel;
 use Illuminate\Contracts\Queue\QueueableCollection;
 use Illuminate\Contracts\Queue\QueueableEntity;
@@ -143,6 +144,13 @@ abstract class Model implements Arrayable, ArrayAccess, CanBeEscapedWhenCastToSt
      */
     protected static $dispatcher;
 
+    /**
+     * The models that are currently being booted.
+     *
+     * @var array
+     */
+    protected static $booting = [];
+
     /**
      * The array of booted models.
      *
@@ -286,12 +294,20 @@ public function __construct(array $attributes = [])
     protected function bootIfNotBooted()
     {
         if (! isset(static::$booted[static::class])) {
-            static::$booted[static::class] = true;
+            if (isset(static::$booting[static::class])) {
+                throw new LogicException('The ['.__METHOD__.'] method may not be called on model ['.static::class.'] while it is being booted.');
+            }
+
+            static::$booting[static::class] = true;
 
             $this->fireModelEvent('booting', false);
 
             static::booting();
             static::boot();
+
+            static::$booted[static::class] = true;
+            unset(static::$booting[static::class]);
+
             static::booted();
 
             static::$bootedCallbacks[static::class] ??= [];

tests/Database/DatabaseEloquentModelTest.php

@@ -3330,6 +3330,21 @@ public function testUseFactoryAttribute()
         $this->assertEquals(EloquentModelWithUseFactoryAttribute::class, $factory->modelName());
         $this->assertEquals('test name', $instance->name); // Small smoke test to ensure the factory is working
     }
+
+    public function testNestedModelBootingIsDisallowed()
+    {
+        $this->expectExceptionMessageMatches('/The \[(.+)] method may not be called on model \[(.+)\] while it is being booted\./');
+
+        $model = new class extends Model
+        {
+            protected static function boot()
+            {
+                parent::boot();
+
+                $tableName = (new static())->getTable();
+            }
+        };
+    }
 }
 
 class EloquentTestObserverStub