[12.x] Fix prevent group attribute pollution in schedule (#56677)

* fix: prevent group attribute pollution in schedule

Use clone to ensure group attributes are isolated and not affected by reference issues.

Fixes: #56497

* test: add grouped schedule execution tests with time-based scenarios

Author: People-Sea

src/Illuminate/Console/Scheduling/Schedule.php

@@ -312,7 +312,7 @@ public function group(Closure $events)
             throw new RuntimeException('Invoke an attribute method such as Schedule::daily() before defining a schedule group.');
         }
 
-        $this->groupStack[] = $this->attributes;
+        $this->groupStack[] = clone $this->attributes;
 
         $events($this);
 

tests/Integration/Console/Scheduling/ScheduleGroupTest.php

@@ -5,6 +5,7 @@
 namespace Illuminate\Tests\Integration\Console\Scheduling;
 
 use Illuminate\Console\Scheduling\Schedule as ScheduleClass;
+use Illuminate\Support\Carbon;
 use Illuminate\Support\Facades\Schedule;
 use Orchestra\Testbench\TestCase;
 use PHPUnit\Framework\Attributes\DataProvider;
@@ -117,4 +118,66 @@ public static function groupAttributes(): array
             'withoutOverlapping' => ['withoutOverlapping', rand(1000, 1400)],
         ];
     }
+
+    #[DataProvider('scheduleTestCases')]
+    public function testGroupedScheduleExecution($time, $expected, $description)
+    {
+        Carbon::setTestNow($time);
+        $app = app();
+
+        Schedule::days([1, 2, 3, 4, 5, 6])->group(function () {
+            Schedule::between('07:00', '08:00')->group(function () {
+                Schedule::call(fn () => 'Task 1')->everyMinute();
+                Schedule::call(fn () => 'Task 2')->everyFiveMinutes();
+            });
+
+            Schedule::call(fn () => 'Task 3')->at('08:05');
+        });
+
+        $events = Schedule::events();
+
+        foreach (array_keys($expected) as $index => $task) {
+            $this->assertTaskExecution(
+                $events[$index],
+                $app,
+                $expected[$task],
+                "[$description] $task should ".($expected[$task] ? 'run' : 'not run')
+            );
+        }
+
+        Carbon::setTestNow();
+    }
+
+    private function assertTaskExecution($event, $app, $expected, $message): void
+    {
+        $this->assertSame(
+            $expected,
+            $event->filtersPass($app) && $event->isDue($app),
+            $message
+        );
+    }
+
+    public static function scheduleTestCases()
+    {
+        return [
+            [
+                Carbon::create(2024, 1, 1, 7, 30),
+                [
+                    'Task 1' => true,
+                    'Task 2' => true,
+                    'Task 3' => false,
+                ],
+                'Tasks at 07:30',
+            ],
+            [
+                Carbon::create(2024, 1, 1, 8, 5),
+                [
+                    'Task 1' => false,
+                    'Task 2' => false,
+                    'Task 3' => true,
+                ],
+                'Tasks at 08:05',
+            ],
+        ];
+    }
 }