Add tests for Model::preventAccessingMissingAttributes() (#44645)

Author: axlon

tests/Database/DatabaseEloquentModelTest.php

@@ -2320,30 +2320,85 @@ public function testWithoutTouchingOnCallback()
         $this->assertTrue($called);
     }
 
-    public function testAccessingMissingAttributes()
+    public function testThrowsWhenAccessingMissingAttributes()
     {
+        $originalMode = Model::preventsAccessingMissingAttributes();
+        Model::preventAccessingMissingAttributes();
+
+        try {
+            $model = new EloquentModelStub(['id' => 1]);
+            $model->exists = true;
+
+            $this->assertEquals(1, $model->id);
+            $this->expectException(MissingAttributeException::class);
+
+            $model->this_attribute_does_not_exist;
+        } finally {
+            Model::preventAccessingMissingAttributes($originalMode);
+        }
+    }
+
+    public function testDoesntThrowWhenAccessingMissingAttributesOnModelThatIsNotSaved()
+    {
+        $originalMode = Model::preventsAccessingMissingAttributes();
+        Model::preventAccessingMissingAttributes();
+
         try {
-            Model::preventAccessingMissingAttributes(false);
+            $model = new EloquentModelStub(['id' => 1]);
+            $model->exists = false;
+
+            $this->assertEquals(1, $model->id);
+            $this->assertNull($model->this_attribute_does_not_exist);
+        } finally {
+            Model::preventAccessingMissingAttributes($originalMode);
+        }
+    }
 
+    public function testDoesntThrowWhenAccessingMissingAttributesOnModelThatWasRecentlyCreated()
+    {
+        $originalMode = Model::preventsAccessingMissingAttributes();
+        Model::preventAccessingMissingAttributes();
+
+        try {
             $model = new EloquentModelStub(['id' => 1]);
             $model->exists = true;
+            $model->wasRecentlyCreated = true;
 
-            // Default behavior
             $this->assertEquals(1, $model->id);
             $this->assertNull($model->this_attribute_does_not_exist);
+        } finally {
+            Model::preventAccessingMissingAttributes($originalMode);
+        }
+    }
 
-            Model::preventAccessingMissingAttributes(true);
+    public function testDoesntThrowWhenAssigningMissingAttributes()
+    {
+        $originalMode = Model::preventsAccessingMissingAttributes();
+        Model::preventAccessingMissingAttributes();
 
-            // "preventAccessingMissingAttributes" behavior
-            $this->expectException(MissingAttributeException::class);
-            $model->this_attribute_does_not_exist;
+        try {
+            $model = new EloquentModelStub(['id' => 1]);
+            $model->exists = true;
+
+            $model->this_attribute_does_not_exist = 'now it does';
+        } finally {
+            Model::preventAccessingMissingAttributes($originalMode);
+        }
+    }
+
+    public function testDoesntThrowWhenTestingMissingAttributes()
+    {
+        $originalMode = Model::preventsAccessingMissingAttributes();
+        Model::preventAccessingMissingAttributes();
+
+        try {
+            $model = new EloquentModelStub(['id' => 1]);
+            $model->exists = true;
 
-            // Ensure that unsaved models do not trigger the exception
-            $newModel = new EloquentModelStub(['id' => 2]);
-            $this->assertEquals(2, $newModel->id);
-            $this->assertNull($newModel->this_attribute_does_not_exist);
+            $this->assertTrue(isset($model->id));
+            $this->assertFalse(isset($model->this_attribute_does_not_exist));
         } finally {
-            Model::preventAccessingMissingAttributes(false);
+            Model::preventAccessingMissingAttributes($originalMode);
         }
     }