Fix trashed implicitBinding with child with no softdelete (#41282) (#41814)

(cherry picked from commit b8be411)

Co-authored-by: Jori Stein <[email protected]>

Author: BrandonSurowiec

src/Illuminate/Routing/ImplicitRouteBinding.php

@@ -43,7 +43,7 @@ public static function resolveForRoute($container, $route)
                         : 'resolveRouteBinding';
 
             if ($parent instanceof UrlRoutable && ($route->enforcesScopedBindings() || array_key_exists($parameterName, $route->bindingFields()))) {
-                $childRouteBindingMethod = $route->allowsTrashedBindings()
+                $childRouteBindingMethod = $route->allowsTrashedBindings() && in_array(SoftDeletes::class, class_uses_recursive($instance))
                             ? 'resolveSoftDeletableChildRouteBinding'
                             : 'resolveChildRouteBinding';
 

tests/Integration/Routing/ImplicitRouteBindingTest.php

@@ -142,6 +142,35 @@ public function testEnforceScopingImplicitRouteBindings()
         $response->assertNotFound();
     }
 
+    public function testEnforceScopingImplicitRouteBindingsWithTrashedAndChildWithNoSoftDeleteTrait()
+    {
+        $user = ImplicitBindingUser::create(['name' => 'Dries']);
+
+        $post = $user->posts()->create();
+
+        $user->delete();
+
+        config(['app.key' => str_repeat('a', 32)]);
+        Route::scopeBindings()->group(function () {
+            Route::get('/user/{user}/post/{post}', function (ImplicitBindingUser $user, ImplicitBindingPost $post) {
+                return [$user, $post];
+            })->middleware(['web'])->withTrashed();
+        });
+
+        $response = $this->getJson("/user/{$user->id}/post/{$post->id}");
+        $response->assertOk();
+        $response->assertJson([
+            [
+                'id' => $user->id,
+                'name' => $user->name,
+            ],
+            [
+                'id' => 1,
+                'user_id' => 1,
+            ],
+        ]);
+    }
+
     public function testEnforceScopingImplicitRouteBindingsWithRouteCachingEnabled()
     {
         $user = ImplicitBindingUser::create(['name' => 'Dries']);