[8.x] Throw deprecation errors in CI (#40324)

* Throw deprecation errors in CI

* Fix return types

* minimum ramsey/collection version

* wip

* Bump dotenv

* wip

Author: driesvints

.github/workflows/tests.yml

@@ -50,6 +50,7 @@ jobs:
         with:
           php-version: ${{ matrix.php }}
           extensions: dom, curl, libxml, mbstring, zip, pcntl, pdo, sqlite, pdo_sqlite, gd, redis, memcached
+          ini-values: error_reporting=E_ALL
           tools: composer:v2
           coverage: none
 
@@ -66,7 +67,7 @@ jobs:
         with:
           timeout_minutes: 5
           max_attempts: 5
-          command: composer require league/commonmark:^2.0.2 phpunit/phpunit:^9.5.8 --no-interaction --no-update
+          command: composer require league/commonmark:^2.0.2 phpunit/phpunit:^9.5.8 ramsey/collection:^1.2 brick/math:^0.9.3 --no-interaction --no-update
         if: matrix.php >= 8.1
 
       - name: Install dependencies

composer.json

@@ -43,7 +43,7 @@
         "symfony/routing": "^5.4",
         "symfony/var-dumper": "^5.4",
         "tijsverkoyen/css-to-inline-styles": "^2.2.2",
-        "vlucas/phpdotenv": "^5.2",
+        "vlucas/phpdotenv": "^5.4.1",
         "voku/portable-ascii": "^1.4.8"
     },
     "replace": {

src/Illuminate/Support/composer.json

@@ -46,7 +46,7 @@
         "ramsey/uuid": "Required to use Str::uuid() (^4.2.2).",
         "symfony/process": "Required to use the composer class (^5.4).",
         "symfony/var-dumper": "Required to use the dd function (^5.4).",
-        "vlucas/phpdotenv": "Required to use the Env class and env helper (^5.2)."
+        "vlucas/phpdotenv": "Required to use the Env class and env helper (^5.4.1)."
     },
     "config": {
         "sort-packages": true

tests/Support/SupportFacadeTest.php

@@ -94,22 +94,23 @@ public function instance($key, $instance)
         $this->attributes[$key] = $instance;
     }
 
-    public function offsetExists($offset)
+    public function offsetExists($offset): bool
     {
         return isset($this->attributes[$offset]);
     }
 
+    #[\ReturnTypeWillChange]
     public function offsetGet($key)
     {
         return $this->attributes[$key];
     }
 
-    public function offsetSet($key, $value)
+    public function offsetSet($key, $value): void
     {
         $this->attributes[$key] = $value;
     }
 
-    public function offsetUnset($key)
+    public function offsetUnset($key): void
     {
         unset($this->attributes[$key]);
     }

tests/Support/SupportHelpersTest.php

@@ -795,22 +795,23 @@ public function __construct($attributes = [])
         $this->attributes = $attributes;
     }
 
-    public function offsetExists($offset)
+    public function offsetExists($offset): bool
     {
         return array_key_exists($offset, $this->attributes);
     }
 
+    #[\ReturnTypeWillChange]
     public function offsetGet($offset)
     {
         return $this->attributes[$offset];
     }
 
-    public function offsetSet($offset, $value)
+    public function offsetSet($offset, $value): void
     {
         $this->attributes[$offset] = $value;
     }
 
-    public function offsetUnset($offset)
+    public function offsetUnset($offset): void
     {
         unset($this->attributes[$offset]);
     }