[12.x] Fix/memory improvement (#56345)

CharrafiMed · taylorotwell · web-flow · commit 9499a6c06db6 · 2025-07-20T13:38:44.000-05:00
* wip

* fix failling test

* Update CompilesComponents.php

* Update BladePropsTest.php

---------

Co-authored-by: Taylor Otwell &lt;taylor@laravel.com&gt;
diff --git a/src/Illuminate/View/Compilers/Concerns/CompilesComponents.php b/src/Illuminate/View/Compilers/Concerns/CompilesComponents.php
@@ -185,7 +185,7 @@ protected function compileProps($expression)
     if (array_key_exists(\$__key, \$__defined_vars)) unset(\$\$__key);
 }
 
-unset(\$__defined_vars); ?>";
+unset(\$__defined_vars, \$__key, \$__value); ?>";
     }
 
     /**
diff --git a/tests/View/Blade/BladePropsTest.php b/tests/View/Blade/BladePropsTest.php
@@ -36,7 +36,7 @@ public function testPropsAreCompiled()
     if (array_key_exists($__key, $__defined_vars)) unset($$__key);
 }
 
-unset($__defined_vars); ?>', $this->compiler->compileString('@props([\'one\' => true, \'two\' => \'string\'])'));
+unset($__defined_vars, $__key, $__value); ?>', $this->compiler->compileString('@props([\'one\' => true, \'two\' => \'string\'])'));
     }
 
     public function testPropsAreExtractedFromParentAttributesCorrectly()

Original file line number	Diff line number	Diff line change
`@@ -185,7 +185,7 @@ protected function compileProps($expression)`
`185`	`185`	`if (array_key_exists(\$__key, \$__defined_vars)) unset(\$\$__key);`
`186`	`186`	`}`
`187`	`187`
`188`		`-unset(\$__defined_vars); ?>";`
	`188`	`+unset(\$__defined_vars, \$__key, \$__value); ?>";`
`189`	`189`	`}`
`190`	`190`
`191`	`191`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ public function testPropsAreCompiled()`
`36`	`36`	`if (array_key_exists($__key, $__defined_vars)) unset($$__key);`
`37`	`37`	`}`
`38`	`38`
`39`		`-unset($__defined_vars); ?>', $this->compiler->compileString('@props([\'one\' => true, \'two\' => \'string\'])'));`
	`39`	`+unset($__defined_vars, $__key, $__value); ?>', $this->compiler->compileString('@props([\'one\' => true, \'two\' => \'string\'])'));`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`public function testPropsAreExtractedFromParentAttributesCorrectly()`