improve numeric comparison for custom casts (#49504)

Author: imahmood

src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php

@@ -2101,7 +2101,7 @@ public function originalIsEquivalent($key)
         }
 
         return is_numeric($attribute) && is_numeric($original)
-            && strcmp((string) $attribute, (string) $original) === 0;
+            && BigDecimal::of($attribute)->isEqualTo($original);
     }
 
     /**

tests/Integration/Database/DatabaseEloquentModelCustomCastingTest.php

@@ -169,6 +169,33 @@ public function testDeviableCasts()
         $this->assertSame((new Decimal('320.988'))->getValue(), $model->price->getValue());
     }
 
+    public function testDirtyOnCustomNumericCasts()
+    {
+        $model = new TestEloquentModelWithCustomCast;
+        $model->price = '123.00';
+        $model->save();
+
+        $this->assertFalse($model->isDirty());
+
+        $model->price = '123.00';
+        $this->assertFalse($model->isDirty('price'));
+
+        $model->price = '123.0';
+        $this->assertFalse($model->isDirty('price'));
+
+        $model->price = '123';
+        $this->assertFalse($model->isDirty('price'));
+
+        $model->price = '00123.00';
+        $this->assertFalse($model->isDirty('price'));
+
+        $model->price = '123.4000';
+        $this->assertTrue($model->isDirty('price'));
+
+        $model->price = '123.0004';
+        $this->assertTrue($model->isDirty('price'));
+    }
+
     public function testSerializableCasts()
     {
         $model = new TestEloquentModelWithCustomCast;