Replace file_exists with is_file in hot code (#33124)

Author: GrahamCampbell

src/Illuminate/Console/Scheduling/Event.php

@@ -475,7 +475,7 @@ protected function ensureOutputIsBeingCaptured()
      */
     protected function emailOutput(Mailer $mailer, $addresses, $onlyIfOutputExists = false)
     {
-        $text = file_exists($this->output) ? file_get_contents($this->output) : '';
+        $text = is_file($this->output) ? file_get_contents($this->output) : '';
 
         if ($onlyIfOutputExists && empty($text)) {
             return;
@@ -833,7 +833,7 @@ public function onFailureWithOutput(Closure $callback, $onlyIfOutputExists = fal
     protected function withOutputCallback(Closure $callback, $onlyIfOutputExists = false)
     {
         return function (Container $container) use ($callback, $onlyIfOutputExists) {
-            $output = $this->output && file_exists($this->output) ? file_get_contents($this->output) : '';
+            $output = $this->output && is_file($this->output) ? file_get_contents($this->output) : '';
 
             return $onlyIfOutputExists && empty($output)
                             ? null

src/Illuminate/Database/Console/Migrations/MigrateCommand.php

@@ -129,7 +129,7 @@ protected function loadSchemaState()
         // continue with the standard migration operation as normal without errors.
         if ($connection instanceof SQLiteConnection ||
             $connection instanceof SqlServerConnection ||
-            ! file_exists($path = $this->schemaPath($connection))) {
+            ! is_file($path = $this->schemaPath($connection))) {
             return;
         }
 

src/Illuminate/Database/Console/Seeds/SeederMakeCommand.php

@@ -55,7 +55,7 @@ protected function getStub()
      */
     protected function resolveStubPath($stub)
     {
-        return file_exists($customPath = $this->laravel->basePath(trim($stub, '/')))
+        return is_file($customPath = $this->laravel->basePath(trim($stub, '/')))
             ? $customPath
             : __DIR__.$stub;
     }

src/Illuminate/Foundation/AliasLoader.php

@@ -100,7 +100,7 @@ protected function loadFacade($alias)
      */
     protected function ensureFacadeExists($alias)
     {
-        if (file_exists($path = storage_path('framework/cache/facade-'.sha1($alias).'.php'))) {
+        if (is_file($path = storage_path('framework/cache/facade-'.sha1($alias).'.php'))) {
             return $path;
         }
 

src/Illuminate/Foundation/Application.php

@@ -957,7 +957,7 @@ public function getCachedPackagesPath()
      */
     public function configurationIsCached()
     {
-        return file_exists($this->getCachedConfigPath());
+        return is_file($this->getCachedConfigPath());
     }
 
     /**
@@ -1048,7 +1048,7 @@ public function addAbsoluteCachePathPrefix($prefix)
      */
     public function isDownForMaintenance()
     {
-        return file_exists($this->storagePath().'/framework/down');
+        return is_file($this->storagePath().'/framework/down');
     }
 
     /**

src/Illuminate/Foundation/Bootstrap/LoadConfiguration.php

@@ -24,7 +24,7 @@ public function bootstrap(Application $app)
         // First we will see if we have a cache configuration file. If we do, we'll load
         // the configuration items from that file so that it is very quick. Otherwise
         // we will need to spin through every configuration file and load them all.
-        if (file_exists($cached = $app->getCachedConfigPath())) {
+        if (is_file($cached = $app->getCachedConfigPath())) {
             $items = require $cached;
 
             $loadedFromCache = true;

src/Illuminate/Foundation/Bootstrap/LoadEnvironmentVariables.php

@@ -68,7 +68,7 @@ protected function checkForSpecificEnvironmentFile($app)
      */
     protected function setEnvironmentFilePath($app, $file)
     {
-        if (file_exists($app->environmentPath().'/'.$file)) {
+        if (is_file($app->environmentPath().'/'.$file)) {
             $app->loadEnvironmentFrom($file);
 
             return true;

src/Illuminate/Foundation/ComposerScripts.php

@@ -54,11 +54,11 @@ protected static function clearCompiled()
     {
         $laravel = new Application(getcwd());
 
-        if (file_exists($servicesPath = $laravel->getCachedServicesPath())) {
+        if (is_file($servicesPath = $laravel->getCachedServicesPath())) {
             @unlink($servicesPath);
         }
 
-        if (file_exists($packagesPath = $laravel->getCachedPackagesPath())) {
+        if (is_file($packagesPath = $laravel->getCachedPackagesPath())) {
             @unlink($packagesPath);
         }
     }

src/Illuminate/Foundation/Console/ClearCompiledCommand.php

@@ -27,11 +27,11 @@ class ClearCompiledCommand extends Command
      */
     public function handle()
     {
-        if (file_exists($servicesPath = $this->laravel->getCachedServicesPath())) {
+        if (is_file($servicesPath = $this->laravel->getCachedServicesPath())) {
             @unlink($servicesPath);
         }
 
-        if (file_exists($packagesPath = $this->laravel->getCachedPackagesPath())) {
+        if (is_file($packagesPath = $this->laravel->getCachedPackagesPath())) {
             @unlink($packagesPath);
         }
 

src/Illuminate/Foundation/Console/DownCommand.php

@@ -34,7 +34,7 @@ class DownCommand extends Command
     public function handle()
     {
         try {
-            if (file_exists(storage_path('framework/down'))) {
+            if (is_file(storage_path('framework/down'))) {
                 $this->comment('Application is already down.');
 
                 return 0;