[12.x] use limit() in place of take() (#56080)

* use `limit()` in place of `take()`

in all of these changes, `take()` is a direct alias of the `limit()` method, and performs no additional logic.  switching to directly calling the `limit()` method means less code execution (minimallly better performance) and reduces the call stack (nice for debugging).

a bit more subjective, but I would also argue that "limit" is a little clearer semantically about what it is doing to the query, whereas "take" has the implication that you're selecting everything and then taking a subset of that result.

* fix test mock

---------

Co-authored-by: Taylor Otwell <[email protected]>

Author: browner12

src/Illuminate/Bus/DatabaseBatchRepository.php

@@ -59,7 +59,7 @@ public function get($limit = 50, $before = null)
     {
         return $this->connection->table($this->table)
             ->orderByDesc('id')
-            ->take($limit)
+            ->limit($limit)
             ->when($before, fn ($q) => $q->where('id', '<', $before))
             ->get()
             ->map(function ($batch) {
@@ -247,7 +247,7 @@ public function prune(DateTimeInterface $before)
         $totalDeleted = 0;
 
         do {
-            $deleted = $query->take(1000)->delete();
+            $deleted = $query->limit(1000)->delete();
 
             $totalDeleted += $deleted;
         } while ($deleted !== 0);
@@ -270,7 +270,7 @@ public function pruneUnfinished(DateTimeInterface $before)
         $totalDeleted = 0;
 
         do {
-            $deleted = $query->take(1000)->delete();
+            $deleted = $query->limit(1000)->delete();
 
             $totalDeleted += $deleted;
         } while ($deleted !== 0);
@@ -293,7 +293,7 @@ public function pruneCancelled(DateTimeInterface $before)
         $totalDeleted = 0;
 
         do {
-            $deleted = $query->take(1000)->delete();
+            $deleted = $query->limit(1000)->delete();
 
             $totalDeleted += $deleted;
         } while ($deleted !== 0);

src/Illuminate/Database/Concerns/BuildsQueries.php

@@ -363,7 +363,7 @@ protected function orderedLazyById($chunkSize = 1000, $column = null, $alias = n
      */
     public function first($columns = ['*'])
     {
-        return $this->take(1)->get($columns)->first();
+        return $this->limit(1)->get($columns)->first();
     }
 
     /**
@@ -395,7 +395,7 @@ public function firstOrFail($columns = ['*'], $message = null)
      */
     public function sole($columns = ['*'])
     {
-        $result = $this->take(2)->get($columns);
+        $result = $this->limit(2)->get($columns);
 
         $count = $result->count();
 

src/Illuminate/Database/Eloquent/Builder.php

@@ -1119,7 +1119,7 @@ public function simplePaginate($perPage = null, $columns = ['*'], $pageName = 'p
         // Next we will set the limit and offset for this query so that when we get the
         // results we get the proper section of results. Then, we'll create the full
         // paginator instances for these results with the given page and per page.
-        $this->offset(($page - 1) * $perPage)->take($perPage + 1);
+        $this->offset(($page - 1) * $perPage)->limit($perPage + 1);
 
         return $this->simplePaginator($this->get($columns), $perPage, $page, [
             'path' => Paginator::resolveCurrentPath(),

src/Illuminate/Database/Eloquent/Relations/BelongsToMany.php

@@ -841,7 +841,7 @@ public function firstWhere($column, $operator = null, $value = null, $boolean =
      */
     public function first($columns = ['*'])
     {
-        $results = $this->take(1)->get($columns);
+        $results = $this->limit(1)->get($columns);
 
         return count($results) > 0 ? $results->first() : null;
     }

src/Illuminate/Database/Eloquent/Relations/HasOneOrManyThrough.php

@@ -279,7 +279,7 @@ public function firstWhere($column, $operator = null, $value = null, $boolean =
      */
     public function first($columns = ['*'])
     {
-        $results = $this->take(1)->get($columns);
+        $results = $this->limit(1)->get($columns);
 
         return count($results) > 0 ? $results->first() : null;
     }

src/Illuminate/Database/Eloquent/Relations/Relation.php

@@ -186,7 +186,7 @@ public function getEager()
      */
     public function sole($columns = ['*'])
     {
-        $result = $this->take(2)->get($columns);
+        $result = $this->limit(2)->get($columns);
 
         $count = $result->count();
 

src/Illuminate/Database/Migrations/DatabaseMigrationRepository.php

@@ -64,7 +64,9 @@ public function getMigrations($steps)
 
         return $query->orderBy('batch', 'desc')
             ->orderBy('migration', 'desc')
-            ->take($steps)->get()->all();
+            ->limit($steps)
+            ->get()
+            ->all();
     }
 
     /**

src/Illuminate/Queue/Failed/DatabaseFailedJobProvider.php

@@ -136,7 +136,7 @@ public function prune(DateTimeInterface $before)
         $totalDeleted = 0;
 
         do {
-            $deleted = $query->take(1000)->delete();
+            $deleted = $query->limit(1000)->delete();
 
             $totalDeleted += $deleted;
         } while ($deleted !== 0);

src/Illuminate/Queue/Failed/DatabaseUuidFailedJobProvider.php

@@ -149,7 +149,7 @@ public function prune(DateTimeInterface $before)
         $totalDeleted = 0;
 
         do {
-            $deleted = $query->take(1000)->delete();
+            $deleted = $query->limit(1000)->delete();
 
             $totalDeleted += $deleted;
         } while ($deleted !== 0);

tests/Database/DatabaseEloquentBuilderTest.php

@@ -288,7 +288,7 @@ public function testFindWithManyUsingCollection()
     public function testFirstMethod()
     {
         $builder = m::mock(Builder::class.'[get,take]', [$this->getMockQueryBuilder()]);
-        $builder->shouldReceive('take')->with(1)->andReturnSelf();
+        $builder->shouldReceive('limit')->with(1)->andReturnSelf();
         $builder->shouldReceive('get')->with(['*'])->andReturn(new Collection(['bar']));
 
         $result = $builder->first();