Merge pull request #29038 from laravel/5.5-cache-set-multiple

[5.5] Fixed cache repository setMultiple with an iterator

Author: taylorotwell

src/Illuminate/Cache/Repository.php

@@ -229,7 +229,7 @@ public function putMany(array $values, $minutes)
      */
     public function setMultiple($values, $ttl = null)
     {
-        $this->putMany($values, $ttl);
+        $this->putMany(is_array($values) ? $values : iterator_to_array($values), $ttl);
     }
 
     /**

tests/Cache/CacheRepositoryTest.php

@@ -5,6 +5,7 @@
 use DateTime;
 use DateInterval;
 use Mockery as m;
+use ArrayIterator;
 use DateTimeImmutable;
 use Illuminate\Support\Carbon;
 use PHPUnit\Framework\TestCase;
@@ -113,14 +114,22 @@ public function testPuttingMultipleItemsInCache()
         $repo->put(['foo' => 'bar', 'bar' => 'baz'], 1);
     }
 
-    public function testSettingMultipleItemsInCache()
+    public function testSettingMultipleItemsInCacheArray()
     {
         // Alias of PuttingMultiple
         $repo = $this->getRepository();
         $repo->getStore()->shouldReceive('putMany')->once()->with(['foo' => 'bar', 'bar' => 'baz'], 1);
         $repo->setMultiple(['foo' => 'bar', 'bar' => 'baz'], 1);
     }
 
+    public function testSettingMultipleItemsInCacheIterator()
+    {
+        // Alias of PuttingMultiple
+        $repo = $this->getRepository();
+        $repo->getStore()->shouldReceive('putMany')->once()->with(['foo' => 'bar', 'bar' => 'baz'], 1);
+        $repo->setMultiple(new ArrayIterator(['foo' => 'bar', 'bar' => 'baz']), 1);
+    }
+
     public function testPutWithDatetimeInPastOrZeroSecondsDoesntSaveItem()
     {
         $repo = $this->getRepository();