[9.x]Improve test for pull method in Collection (#43394)

moharami · web-flow · commit abf06591936a · 2022-07-24T09:48:55.000-05:00
diff --git a/tests/Support/SupportCollectionTest.php b/tests/Support/SupportCollectionTest.php
@@ -3684,13 +3684,21 @@ public function testPullRetrievesItemFromCollection()
         $c = new Collection(['foo', 'bar']);
 
         $this->assertSame('foo', $c->pull(0));
+        $this->assertSame('bar', $c->pull(1));
+
+        $c = new Collection(['foo', 'bar']);
+
+        $this->assertNull($c->pull(-1));
+        $this->assertNull($c->pull(2));
     }
 
     public function testPullRemovesItemFromCollection()
     {
         $c = new Collection(['foo', 'bar']);
         $c->pull(0);
         $this->assertEquals([1 => 'bar'], $c->all());
+        $c->pull(1);
+        $this->assertEquals([], $c->all());
     }
 
     public function testPullRemovesItemFromNestedCollection()

Original file line number	Diff line number	Diff line change
`@@ -3684,13 +3684,21 @@ public function testPullRetrievesItemFromCollection()`
`3684`	`3684`	`$c = new Collection(['foo', 'bar']);`
`3685`	`3685`
`3686`	`3686`	`$this->assertSame('foo', $c->pull(0));`
	`3687`	`+ $this->assertSame('bar', $c->pull(1));`
	`3688`	`+`
	`3689`	`+ $c = new Collection(['foo', 'bar']);`
	`3690`	`+`
	`3691`	`+ $this->assertNull($c->pull(-1));`
	`3692`	`+ $this->assertNull($c->pull(2));`
`3687`	`3693`	`}`
`3688`	`3694`
`3689`	`3695`	`public function testPullRemovesItemFromCollection()`
`3690`	`3696`	`{`
`3691`	`3697`	`$c = new Collection(['foo', 'bar']);`
`3692`	`3698`	`$c->pull(0);`
`3693`	`3699`	`$this->assertEquals([1 => 'bar'], $c->all());`
	`3700`	`+ $c->pull(1);`
	`3701`	`+ $this->assertEquals([], $c->all());`
`3694`	`3702`	`}`
`3695`	`3703`
`3696`	`3704`	`public function testPullRemovesItemFromNestedCollection()`