[7.x] Fix SendQueuedNotifications notifiables property type (#31675)

* The notifiables property is now always a collection, as it's documentation suggests

* Update SendQueuedNotifications.php

Co-authored-by: Taylor Otwell <[email protected]>

Author: axlon

src/Illuminate/Notifications/SendQueuedNotifications.php

@@ -6,6 +6,7 @@
 use Illuminate\Contracts\Queue\ShouldQueue;
 use Illuminate\Queue\InteractsWithQueue;
 use Illuminate\Queue\SerializesModels;
+use Illuminate\Support\Collection;
 
 class SendQueuedNotifications implements ShouldQueue
 {
@@ -57,8 +58,8 @@ class SendQueuedNotifications implements ShouldQueue
     public function __construct($notifiables, $notification, array $channels = null)
     {
         $this->channels = $channels;
-        $this->notifiables = $notifiables;
         $this->notification = $notification;
+        $this->notifiables = Collection::wrap($notifiables);
         $this->tries = property_exists($notification, 'tries') ? $notification->tries : null;
         $this->timeout = property_exists($notification, 'timeout') ? $notification->timeout : null;
     }

tests/Notifications/NotificationSendQueuedNotificationTest.php

@@ -4,6 +4,7 @@
 
 use Illuminate\Notifications\ChannelManager;
 use Illuminate\Notifications\SendQueuedNotifications;
+use Illuminate\Support\Collection;
 use Mockery as m;
 use PHPUnit\Framework\TestCase;
 
@@ -18,7 +19,11 @@ public function testNotificationsCanBeSent()
     {
         $job = new SendQueuedNotifications('notifiables', 'notification');
         $manager = m::mock(ChannelManager::class);
-        $manager->shouldReceive('sendNow')->once()->with('notifiables', 'notification', null);
+        $manager->shouldReceive('sendNow')->once()->withArgs(function ($notifiables, $notification, $channels) {
+            return $notifiables instanceof Collection && $notifiables->toArray() === ['notifiables']
+                && $notification === 'notification'
+                && $channels === null;
+        });
         $job->handle($manager);
     }
 }