[9.x] Avoid mutating the $expectedLitener between loops on Event::assertListening (#46095)

* Avoid mutability when normalizing listeners for Event::assertListening

* formatting

---------

Co-authored-by: Taylor Otwell <[email protected]>

Author: phcostabh

src/Illuminate/Support/Testing/Fakes/EventFake.php

@@ -85,21 +85,23 @@ public function assertListening($expectedEvent, $expectedListener)
             $actualListener = (new ReflectionFunction($listenerClosure))
                         ->getStaticVariables()['listener'];
 
+            $normalizedListener = $expectedListener;
+
             if (is_string($actualListener) && Str::contains($actualListener, '@')) {
                 $actualListener = Str::parseCallback($actualListener);
 
                 if (is_string($expectedListener)) {
                     if (Str::contains($expectedListener, '@')) {
-                        $expectedListener = Str::parseCallback($expectedListener);
+                        $normalizedListener = Str::parseCallback($expectedListener);
                     } else {
-                        $expectedListener = [$expectedListener, 'handle'];
+                        $normalizedListener = [$expectedListener, 'handle'];
                     }
                 }
             }
 
-            if ($actualListener === $expectedListener ||
+            if ($actualListener === $normalizedListener ||
                 ($actualListener instanceof Closure &&
-                $expectedListener === Closure::class)) {
+                $normalizedListener === Closure::class)) {
                 PHPUnit::assertTrue(true);
 
                 return;

tests/Integration/Events/EventFakeTest.php

@@ -5,6 +5,7 @@
 use Closure;
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Arr;
 use Illuminate\Support\Facades\Event;
 use Illuminate\Support\Facades\Schema;
 use Orchestra\Testbench\TestCase;
@@ -140,11 +141,20 @@ public function testEventsListedInExceptAreProperlyDispatched()
     public function testAssertListening()
     {
         Event::fake();
-        Event::listen('event', 'listener');
-        Event::listen('event', PostEventSubscriber::class);
-        Event::listen('event', 'Illuminate\\Tests\\Integration\\Events\\PostAutoEventSubscriber@handle');
-        Event::listen('event', [PostEventSubscriber::class, 'foo']);
+
+        $listenersOfSameEventInRandomOrder = Arr::shuffle([
+            'listener',
+            'Illuminate\\Tests\\Integration\\Events\\PostAutoEventSubscriber@handle',
+            PostEventSubscriber::class,
+            [PostEventSubscriber::class, 'foo'],
+        ]);
+
+        foreach ($listenersOfSameEventInRandomOrder as $listener) {
+            Event::listen('event', $listener);
+        }
+
         Event::subscribe(PostEventSubscriber::class);
+
         Event::listen(function (NonImportantEvent $event) {
             // do something
         });