[9.x ] Updated Mailable to prevent duplicated recipients (#45119)

* #45042 - Updated Mailable to prevent duplicated recipients

* #45042 - Updated test cases

* #45042 - Updated test cases to check for multiple addresses in recipients

* formatting

Co-authored-by: Taylor Otwell <[email protected]>

Author: WendellAdriel

src/Illuminate/Mail/Mailable.php

@@ -689,6 +689,11 @@ protected function setAddress($address, $name = null, $property = 'to')
             ];
         }
 
+        $this->{$property} = collect($this->{$property})
+            ->unique('address')
+            ->values()
+            ->all();
+
         return $this;
     }
 

tests/Mail/MailMailableTest.php

@@ -71,10 +71,10 @@ public function testMailableSetsRecipientsCorrectly()
         $mailable->assertHasTo('[email protected]');
 
         $mailable = new WelcomeMailableStub;
-        $mailable->to(collect([new MailableTestUserStub, new MailableTestUserStub]));
+        $mailable->to(collect([new MailableTestUserStub, new MailableTestUserStub, new MailableTestUserStub2]));
         $this->assertEquals([
             ['name' => 'Taylor Otwell', 'address' => '[email protected]'],
-            ['name' => 'Taylor Otwell', 'address' => 'taylor@laravel.com'],
+            ['name' => 'Laravel Framework', 'address' => 'contact@laravel.com'],
         ], $mailable->to);
         $this->assertTrue($mailable->hasTo(new MailableTestUserStub));
         $this->assertTrue($mailable->hasTo('[email protected]'));
@@ -149,10 +149,10 @@ public function testMailableSetsCcRecipientsCorrectly()
         $mailable->assertHasCc('[email protected]');
 
         $mailable = new WelcomeMailableStub;
-        $mailable->cc(collect([new MailableTestUserStub, new MailableTestUserStub]));
+        $mailable->cc(collect([new MailableTestUserStub, new MailableTestUserStub, new MailableTestUserStub2]));
         $this->assertEquals([
             ['name' => 'Taylor Otwell', 'address' => '[email protected]'],
-            ['name' => 'Taylor Otwell', 'address' => 'taylor@laravel.com'],
+            ['name' => 'Laravel Framework', 'address' => 'contact@laravel.com'],
         ], $mailable->cc);
         $this->assertTrue($mailable->hasCc(new MailableTestUserStub));
         $this->assertTrue($mailable->hasCc('[email protected]'));
@@ -238,10 +238,10 @@ public function testMailableSetsBccRecipientsCorrectly()
         $mailable->assertHasBcc('[email protected]');
 
         $mailable = new WelcomeMailableStub;
-        $mailable->bcc(collect([new MailableTestUserStub, new MailableTestUserStub]));
+        $mailable->bcc(collect([new MailableTestUserStub, new MailableTestUserStub, new MailableTestUserStub2]));
         $this->assertEquals([
             ['name' => 'Taylor Otwell', 'address' => '[email protected]'],
-            ['name' => 'Taylor Otwell', 'address' => 'taylor@laravel.com'],
+            ['name' => 'Laravel Framework', 'address' => 'contact@laravel.com'],
         ], $mailable->bcc);
         $this->assertTrue($mailable->hasBcc(new MailableTestUserStub));
         $this->assertTrue($mailable->hasBcc('[email protected]'));
@@ -327,10 +327,10 @@ public function testMailableSetsReplyToCorrectly()
         $mailable->assertHasReplyTo('[email protected]');
 
         $mailable = new WelcomeMailableStub;
-        $mailable->replyTo(collect([new MailableTestUserStub, new MailableTestUserStub]));
+        $mailable->replyTo(collect([new MailableTestUserStub, new MailableTestUserStub, new MailableTestUserStub2]));
         $this->assertEquals([
             ['name' => 'Taylor Otwell', 'address' => '[email protected]'],
-            ['name' => 'Taylor Otwell', 'address' => 'taylor@laravel.com'],
+            ['name' => 'Laravel Framework', 'address' => 'contact@laravel.com'],
         ], $mailable->replyTo);
         $this->assertTrue($mailable->hasReplyTo(new MailableTestUserStub));
         $this->assertTrue($mailable->hasReplyTo('[email protected]'));
@@ -405,10 +405,10 @@ public function testMailableSetsFromCorrectly()
         $mailable->assertFrom('[email protected]');
 
         $mailable = new WelcomeMailableStub;
-        $mailable->from(collect([new MailableTestUserStub, new MailableTestUserStub]));
+        $mailable->from(collect([new MailableTestUserStub, new MailableTestUserStub, new MailableTestUserStub2]));
         $this->assertEquals([
             ['name' => 'Taylor Otwell', 'address' => '[email protected]'],
-            ['name' => 'Taylor Otwell', 'address' => 'taylor@laravel.com'],
+            ['name' => 'Laravel Framework', 'address' => 'contact@laravel.com'],
         ], $mailable->from);
         $this->assertTrue($mailable->hasFrom(new MailableTestUserStub));
         $this->assertTrue($mailable->hasFrom('[email protected]'));
@@ -1018,6 +1018,12 @@ class MailableTestUserStub
     public $email = '[email protected]';
 }
 
+class MailableTestUserStub2
+{
+    public $name = 'Laravel Framework';
+    public $email = '[email protected]';
+}
+
 class MailTestAttachable implements Attachable
 {
     public function __construct(protected $attachment)