[11.x] Improves RedirectIfAuthenticated middleware default redirect (#49286)

* Improves `RedirectIfAuthenticated`

* Apply fixes from StyleCI

* Improves sorting

* Improves perf

* formatting

---------

Co-authored-by: StyleCI Bot <[email protected]>
Co-authored-by: Taylor Otwell <[email protected]>

Author: 3 people

src/Illuminate/Auth/Middleware/RedirectIfAuthenticated.php

@@ -5,14 +5,15 @@
 use Closure;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Auth;
+use Illuminate\Support\Facades\Route;
 use Symfony\Component\HttpFoundation\Response;
 
 class RedirectIfAuthenticated
 {
     /**
      * The callback that should be used to generate the authentication redirect path.
      *
-     * @var callable
+     * @var callable|null
      */
     protected static $redirectToCallback;
 
@@ -41,7 +42,29 @@ protected function redirectTo(Request $request): ?string
     {
         return static::$redirectToCallback
             ? call_user_func(static::$redirectToCallback, $request)
-            : '/dashboard';
+            : $this->defaultRedirectUri();
+    }
+
+    /**
+     * Get the default URI the user should be redirected to when they are authenticated.
+     */
+    protected function defaultRedirectUri(): string
+    {
+        foreach (['dashboard', 'home'] as $uri) {
+            if (Route::has($uri)) {
+                return route($uri);
+            }
+        }
+
+        $routes = Route::getRoutes()->get('GET');
+
+        foreach (['dashboard', 'home'] as $uri) {
+            if (isset($routes[$uri])) {
+                return '/'.$uri;
+            }
+        }
+
+        return '/';
     }
 
     /**

src/Illuminate/Foundation/Configuration/ApplicationBuilder.php

@@ -191,8 +191,7 @@ public function withMiddleware(callable $callback)
     {
         $this->app->afterResolving(HttpKernel::class, function ($kernel) use ($callback) {
             $middleware = (new Middleware)
-                ->auth(redirectTo: fn () => route('login'))
-                ->guest(redirectTo: fn () => route('dashboard'));
+                ->auth(redirectTo: fn () => route('login'));
 
             $callback($middleware);
 

tests/Integration/Auth/Middleware/RedirectIfAuthenticatedTest.php

@@ -0,0 +1,108 @@
+<?php
+
+namespace Illuminate\Tests\Integration\Auth\Middleware;
+
+use Illuminate\Auth\Middleware\RedirectIfAuthenticated;
+use Illuminate\Contracts\Routing\Registrar;
+use Illuminate\Support\Str;
+use Illuminate\Tests\Integration\Auth\Fixtures\AuthenticationTestUser;
+use Orchestra\Testbench\Factories\UserFactory;
+use Orchestra\Testbench\TestCase;
+
+class RedirectIfAuthenticatedTest extends TestCase
+{
+    protected function setUp(): void
+    {
+        parent::setUp();
+
+        $this->withoutExceptionHandling();
+
+        /** @var \Illuminate\Contracts\Routing\Registrar $router */
+        $this->router = $this->app->make(Registrar::class);
+
+        $this->router->get('/login', function () {
+            return response('Login Form');
+        })->middleware(RedirectIfAuthenticated::class);
+
+        UserFactory::new()->create();
+
+        $user = AuthenticationTestUser::first();
+        $this->router->get('/login', function () {
+            return response('Login Form');
+        })->middleware(RedirectIfAuthenticated::class);
+
+        UserFactory::new()->create();
+
+        $this->user = AuthenticationTestUser::first();
+    }
+
+    protected function defineEnvironment($app)
+    {
+        $app['config']->set('app.key', Str::random(32));
+        $app['config']->set('auth.providers.users.model', AuthenticationTestUser::class);
+    }
+
+    protected function defineDatabaseMigrations()
+    {
+        $this->loadLaravelMigrations();
+    }
+
+    public function testWhenDashboardNamedRouteIsAvailable()
+    {
+        $this->router->get('/named-dashboard', function () {
+            return response('Named Dashboard');
+        })->name('dashboard');
+
+        $response = $this->actingAs($this->user)->get('/login');
+
+        $response->assertRedirect('/named-dashboard');
+    }
+
+    public function testWhenHomeNamedRouteIsAvailable()
+    {
+        $this->router->get('/named-home', function () {
+            return response('Named Home');
+        })->name('home');
+
+        $response = $this->actingAs($this->user)->get('/login');
+
+        $response->assertRedirect('/named-home');
+    }
+
+    public function testWhenDashboardSlugIsAvailable()
+    {
+        $this->router->get('/dashboard', function () {
+            return response('My Dashboard');
+        });
+
+        $response = $this->actingAs($this->user)->get('/login');
+
+        $response->assertRedirect('/dashboard');
+    }
+
+    public function testWhenHomeSlugIsAvailable()
+    {
+        $this->router->get('/home', function () {
+            return response('My Home');
+        })->name('home');
+
+        $response = $this->actingAs($this->user)->get('/login');
+
+        $response->assertRedirect('/home');
+    }
+
+    public function testWhenHomeOrDashboardAreNotAvailable()
+    {
+        $response = $this->actingAs($this->user)->get('/login');
+
+        $response->assertRedirect('/');
+    }
+
+    public function testWhenGuest()
+    {
+        $response = $this->get('/login');
+
+        $response->assertOk();
+        $response->assertSee('Login Form');
+    }
+}