attempt to fix 43893

Author: taylorotwell

src/Illuminate/Database/Eloquent/Model.php

@@ -441,7 +441,9 @@ public function fill(array $attributes)
     {
         $totallyGuarded = $this->totallyGuarded();
 
-        foreach ($this->fillableFromArray($attributes) as $key => $value) {
+        $fillable = $this->fillableFromArray($attributes);
+
+        foreach ($fillable as $key => $value) {
             // The developers may choose to place some attributes in the "fillable" array
             // which means only those attributes may be set through mass assignment to
             // the model, and all others will just get ignored for security reasons.
@@ -455,6 +457,14 @@ public function fill(array $attributes)
             }
         }
 
+        if (count($attributes) !== count($fillable) &&
+            static::preventsSilentlyDiscardingAttributes()) {
+            throw new MassAssignmentException(sprintf(
+                'Add fillable property to allow mass assignment on [%s].',
+                get_class($this)
+            ));
+        }
+
         return $this;
     }
 

tests/Database/DatabaseEloquentModelTest.php

@@ -1291,10 +1291,14 @@ public function testGuarded()
         $model = new EloquentModelStub;
         $model->guard(['name', 'age']);
         $model->fill(['Foo' => 'bar']);
+
+        Model::preventSilentlyDiscardingAttributes(false);
     }
 
     public function testFillableOverridesGuarded()
     {
+        Model::preventSilentlyDiscardingAttributes(false);
+
         $model = new EloquentModelStub;
         $model->guard([]);
         $model->fillable(['age', 'foo']);