Mail Notifications are not sent

[thecyrilcril]

• Laravel Version: 7.25.0
• PHP Version: 7.3.12
• Database Driver & Version: MariaDB 10.4.10

Description:

I have a project with an Account Model that is meant to send a mail Notification
The mail notification is not sent and I do not receive any error
I have Mailtrap's SMTP setup in the .env file.
here are my files:
##Account Model

<?php

namespace App\Models;

use App\User;
use Carbon\Carbon;
use App\Models\IncomeSetting;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Notifications\Notifiable;

class Account extends Model
{
    use Notifiable;
    protected $guarded = [];
    protected $dates = ['dob', 'created_on'];

    public function routeNotificationForAccount()
    {
      return $this->phone_number;
    }

    public function setDobAttribute($value)
    {
        $this->attributes['dob'] = Carbon::parse($value)->format('Y-m-d');
    }

    public function setCreatedOnAttribute($value)
    {
        $this->attributes['created_on'] = Carbon::parse($value)->format('Y-m-d');
    }

    public function path()
    {
      return "/accounts/clients/{$this->id}";
    }

    public function marketer()
    {
        return $this->belongsTo(User::class, 'marketer_id');
    }

    public function account_balance()
    {
        return $this->hasOne(AccountBalance::class);
    }

    public function income()
    {
        return $this->hasOne(Income::class);
    }

    public function sms_verification()
    {
        return $this->hasOne(SmsVerification::class);
    }

    public function email_verification()
    {
        return $this->hasOne(EmailVerification::class);
    }

    public function sms_verification_settings()
    {
        return SmsVerificationSetting::all()->first();
    }

    public function account_opening_charge_details()
    {
        return IncomeSetting::where('id', self::INCOME_TYPE['account_opening'])->first();
    }

    private const INCOME_TYPE = [
        'account_opening' => 1,
        'loan_application' => 2,
        'loan_interest' => 3,
    ];

}

The store method of the AccountsController

<?php

namespace App\Http\Controllers\Accounts;

use Keygen\Keygen;
use App\Models\Account;
use Illuminate\Http\Request;
use App\Events\AccountCreated;
use App\Models\AccountBalance;
use Illuminate\Support\Facades\DB;
use App\Http\Controllers\Controller;
use App\Http\Requests\CreateAccount;
use Illuminate\Support\Facades\Gate;
use App\Notifications\VerifyPhoneNumber;
use App\Notifications\VerifyEmailAddresss;
use App\Services\Currency\CurrencyAbstract;


class AccountsController extends Controller

{

    ...

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function store(CreateAccount $request, CurrencyAbstract $naira)
    {
        if (Gate::denies('create-accounts')) {
            abort(403, 'Unauthorized.');
        }

        DB::transaction(function () use ($request, $naira) {
            $account = auth()->user()->registers_accounts()->create($request->validated());

            $account->sms_verification()->create([
                'otp' => Keygen::numeric(6)->generate()
            ]);

            $account->account_balance()->create([
                'available' => $naira->toKobo(0),
                'ledger' => $naira->toKobo(0)
            ]);

            $account->income()->create([
                'user_id' => $account->user_id,
                'description' => $account->account_opening_charge_details()->description,
                'amount' => $account->account_opening_charge_details()->amount,
            ]);

            $account->notify(new VerifyEmailAddresss($account));

            // event(new AccountCreated($account));

        });


    }

    ...



}

The VerifyEmailAddresss Notification class

<?php

namespace App\Notifications;

use App\Models\Account;
use Illuminate\Bus\Queueable;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Notifications\Messages\MailMessage;
use Illuminate\Notifications\Notification;

class VerifyEmailAddresss extends Notification implements ShouldQueue
{
    protected $account;

    use Queueable;

    /**
     * Create a new notification instance.
     *
     * @return void
     */
    public function __construct(Account $account)
    {
        //
        $this->account = $account;
    }

    /**
     * Get the notification's delivery channels.
     *
     * @param  mixed  $notifiable
     * @return array
     */
    public function via($notifiable)
    {
        return ['mail'];
    }

    /**
     * Get the mail representation of the notification.
     *
     * @param  mixed  $notifiable
     * @return \Illuminate\Notifications\Messages\MailMessage
     */
    public function toMail($notifiable)
    {
        // dd($notifiable);
        return (new MailMessage)
                    ->line('Please verify your email address by clicking this button below.')
                    ->action('Verify Email', url('/'))
                    ->line('Thank you for using our application!');
    }

    /**
     * Get the array representation of the notification.
     *
     * @param  mixed  $notifiable
     * @return array
     */
    public function toArray($notifiable)
    {
        return [
            //
        ];
    }
}

Mailtrap's config

MAIL_MAILER=smtp
MAIL_HOST=smtp.mailtrap.io
MAIL_PORT=2525
MAIL_USERNAME=5b05605ded388a
MAIL_PASSWORD=3856cf6ab4def7
MAIL_ENCRYPTION=tls
[email protected]
MAIL_FROM_NAME="${APP_NAME}"

Steps To Reproduce:

I run the following test to create a new account and actual notifications(I am not mocking the notifications) get sent as a side effect.

    /** @test */
    public function a_new_account_creates_an_income()
    {
        $this->withoutExceptionHandling();

       ...

        $newAccount = factory('App\Models\Account')->raw();

        $this->post('accounts/clients', $newAccount);


        $this->assertCount(1, Income::all());

    }

[ahmedsayedabdelsalam]

I see that the notification class implements the ShouldQueue Interface
what is the Queue connection in the .env file
if it is not sync are you running the worker ? php artisan queue:work --tries=3

[thecyrilcril]

I see that the notification class implements the ShouldQueue Interface
what is the Queue connection in the .env file
if it is not sync are you running the worker ? php artisan queue:work --tries=3

I test the Notification via a test that tries to create a new account and the notification is a result of that.
from my experience running the queue worker is not necessary when running tests.

[thecyrilcril]

I tried to replicate the action: creating a new account via a route and testing that from the browser and I got the notification. it seems Mail Notifications don't work within a test (I have tried SMS notifications and they do work).
The question now is how I test Mail Notifications

[mailopl]

@seewhy17 have you tried faking your Mail or Notification class in the test itself? Like: Mail::fake() or Notification::fake().

[thecyrilcril]

@mailopl Thanks I finally got it to work, here is my new test with some modifications as bits and pieces of the application as changed a bit.

/** @test */
public function can_send_verify_email_address_notification()
    {
        $this->withoutExceptionHandling();


        $account = factory('App\Models\Account')->create();

        factory('App\Models\EmailVerification')->create([
            'account_id' => $account->id
        ]);

        Notification::fake();


        $account->notify(new VerifyEmailAddress($account));

        Notification::assertSentTo(
            $account,
            VerifyEmailAddress::class,
            function ($notification, $channels) use ($account) {
                $mailData = $notification->toMail($account)->toArray();
                // dd($mailData);
                $this->assertEquals("Hello {$account->firstname}!", $mailData['greeting']);
                $this->assertEquals(route('verify-email', $account->email_verification->code), $mailData['actionUrl']);
                return $notification->account->id === $account->id;
            }
        );

    }