You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In English the typical ending of a letter is "Regards, blaab2". However, in other languages, for example in German, there is no semicolon there. So the correct German greeting would be "Beste Grüße Blaab2".
The current implementation of the notification email includes the semicolon in the markdown file.
I suggest to replace @lang('Regards'),<br> by @lang('Regards,')<br>. This makes the email markdown more localization friendly as users that do not want to have a semicolon here, do not need to vendor export the whole markdown file.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
In English the typical ending of a letter is "Regards, blaab2". However, in other languages, for example in German, there is no semicolon there. So the correct German greeting would be "Beste Grüße Blaab2".
The current implementation of the notification email includes the semicolon in the markdown file.
framework/src/Illuminate/Notifications/resources/views/email.blade.php
Line 46 in 5a748ee
I suggest to replace
@lang('Regards'),<br>by@lang('Regards,')<br>. This makes the email markdown more localization friendly as users that do not want to have a semicolon here, do not need to vendor export the whole markdown file.Beta Was this translation helpful? Give feedback.
All reactions