Model::factory()->has() many unintended rows created

[hsmfawaz]

• Laravel Version: 8.5.0
• PHP Version: 7.3.1.#
• Database Driver & Version: Mysql

Description:

The following seeder should create only 10 family rows as the factory count is 10
But it will create 60 rows

//FamilySeeder.php

Family::factory(10)
              ->has(Invoice::factory()->has(InvoiceItem::factory(5), 'items'), 'invoices')
              ->create();

//InvoiceFactory.php

public function definition()
    {
        return [
            'family_id' => Family::factory(),
            'paid' => $this->faker->boolean,
            'total_price' => $this->faker->randomFloat(2, 0, 999999.99),
            'discount_value' => $this->faker->randomFloat(2, 0, 999999.99),
        ];
    }

//InvoiceItemFactory.php

public function definition()
    {
        return [
            'invoice_id' => Invoice::factory(),
            'product_id' => Product::factory(),
            'price' => $this->faker->randomFloat(2, 0, 999999.99),
            'count' => $this->faker->numberBetween(-10000, 10000),
        ];
    }

Steps To Reproduce:

[driesvints]

Please paste your full model, test and factories. Thanks

[driesvints]

There's still models and factories missing here. It's probably best that you create a test repo. Please commit your custom changes separately from Laravel's skeleton. Try to reproduce it on a fresh install with the minimum amount of code needed.

[hsmfawaz]

Sure i will create the test repo because i faced other wrong behaviors

[hsmfawaz]

This is the commit with full code
https://github.com/hsmfawaz/laravel-issues/commit/180adaabf67865492b462e44cf2b160793d9d832

[driesvints]

I honestly think you have a bug somewhere in your code. Can you maybe try a support channel first? If you can definitely confirm this to be a bug feel free to open up a new issue.

• Laracasts Forums
• Laravel.io Forums
• StackOverflow
• Discord
• Larachat
• IRC

[hsmfawaz]

After some digging inside the factory classes

I got why i got the wrong behavior

1- create a family factory
2- attach invoice factory to the family factor using family_id column (it will create the expected number of rows for the family)
3- when i attach the invoice_items the issue appear why ?

because invoice_items has a relationship called products
and the products table has a family_id column

so it create the unexpected rows

The behavior i expect is
when i group many factory together using relations the group should share the id of each factory
for instance

Family::factory(10)
              ->has(Invoice::factory()->has(InvoiceItem::factory(5), 'items'), 'invoices')
              ->create();

FamilyFactory send family_id to InvoiceFactory then
InvoiceFactory send the family_id and invoice_id to its children
So InvoiceItemFactory get [family_id ,invoice_id] if we did that the family_id inside products will be equal to the familyFactory

[hsmfawaz]

The following syntax solve the problem

public function testCanSeedDataWithTwoLevelRelation()
    {
        $family = Family::factory();
        $products = Product::factory(1)->for($family);
        $invoice = Invoice::factory(5);
        InvoiceItem::factory(1)->has($products)->for($invoice);
        $family->count(10)->has($invoice)->create();
        $this->assertDatabaseCount('families', 10);//expected 10 got 10
        $this->assertDatabaseCount('invoices', 50);// expected 50 got 50
    }

Instead of

 public function testCanSeedDataWithTwoLevelRelation()
    {
        $invoice = Invoice::factory(5)->has(InvoiceItem::factory(1)->has(Product::factory()), 'items');
        Family::factory()->count(10)->has($invoice)->create();
        $this->assertDatabaseCount('families', 10);//expected 10 got 60
        $this->assertDatabaseCount('invoices', 50);// expected 50 got 50
    }

[cvairlis]

Thank you @hsmfawaz
Also if some of the readers still face further issues, I would like to place here one more hint.
I dealt with this for the last 2 days.

I realized that if the Factory of the relation model has two model factories inside, this could lead on creation of multiple records on the base model.

For example:
If we have the following models: User -> hasMany Section -> hasMany -> Post
And we want to create 1 user and 10 sections for this user we should do the following:

User::factory()->has(Section::factory(10))->create();

This should give as 1 user record and 10 section records.

But have in mind the Section factory. If the Section factory has inside the definition the Post::factory, then this could lead to problems.

public function definition(): array
{
    return [
        'user_id' => User::factory(),
        'post_id' => Post::factory(),
        'sample_column_1' => $$this->faker->realText(125),
        'sample_column_2' => $$this->faker->realText(125),
    ];
}

This can lead to having created 11 user records and 10 section records.
Thank you very much, hope this helps.