Replies: 1 comment
-
Seems traits such as |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Suggestion
Rename
getEmailForPasswordReset
->getIdentifierForPasswordReset
, andemail
->identifier
inpassword_resets
table.Why
The default implementation for
DatabaseTokenRepository
assumes that every user has a unique email. I have a customUserProvider
where that isn't the case.I can implement a work-around where
getEmailForPasswordReset
returns a unique key, but it isn't immediately obvious why that's required without diving into the source code.Other
It looks like
getEmailForPasswordReset
is only used byDatabaseTokenRepository
as an identifier.PasswordBroker
uses the user retrieved via the provider directly.The default
CanResetPassword
implementation to use$this->email
as the identifier can remain unchanged.Beta Was this translation helpful? Give feedback.
All reactions