Validation rule "integer" behaviour with "(bool) true"

[danilopolani]

Edit: Moving this into an issue.

---

Currently the validation rule integer passes if the given input is (bool) true because it relies on filter_var($value, FILTER_VALIDATE_INT) which returns 1 for a true input due to internal casting.

Should the integer behaviour be changed (in 9.x/10.x) to return false? An example is better than 1000 words:

filter_var(true, FILTER_VALIDATE_INT); // 1

// Therefore...
$v = Validator::make(
    ['input' => true],
    ['input' => 'required|integer']
);

$v->passes(); // true
$v->validated(); // ['input' => true]

Using this data for any DB interaction (or anything) where a int is expected would throw an exception because it could return a boolean and not only integers despite its name. For a given input true I would expect the validation to fail.

Currently I'm avoiding using the rule in favor of regex:/^[0-9]+$/ (I'm not dealing with negative numbers), but would nice to hear from you about this before creating a "real_integer" custom rule.

[danilopolani]

Solved: #36321 (comment)