Parameters aren't passed to failedRules when using custom rule class

[elambro]

• Laravel Version: 8.21.0
• PHP Version: 8.0.2

Description:

With a custom validation rule, there is no way to add parameters to the $validator->failed() array.

For example, I have a custom rule which warns a user if their email address does not pass DNS, but will pass on a second try.

class ValidEmail extends AbstractRule implements Rule
{
    const AUTO   = 'auto';
    const STRICT = 'strict';
    const WEAK   = 'weak';
    protected $alias = 'valid_email';
    protected $strictness = self::AUTO;

    public function __construct($strictness = self::AUTO)
    {
        if (in_array($strictness, [self::STRICT,self::WEAK,self::AUTO])) {
            $this->strictness = $strictness;
        }
    }

    public function passes($attribute, $value, $parameters = [], $validator = null)
   {
        $this->setStrictnessFrom($parameters);
        if ($this->isStrict()) {
           // ... validate strict
       } else {
          // .... validate weak
       }
   }

The rule also has an alias valid_email which can accept a parameter valid_email:strict or valid_email:weak.

If I use the alias as a rule, I can see the parameter in $validator->failed(). However, there is no way to put the parameter into the failed rules array if the rule is instantiated using the class name, unless I extend the validator (which seems like overkill for this use case).

Proposal

Check if a method exists on the rule class to manually pass in the parameters.

In ValidationRuleParser::parse:

    public static function parse($rules)
    {
        if ($rules instanceof RuleContract) {

            $parameters = method_exists($rules, 'parameters') ? $rules->parameters() : [];

            return [$rules, $parameters];
        }

        if (is_array($rules)) {
            $rules = static::parseArrayRule($rules);
        } else {
            $rules = static::parseStringRule($rules);
        }

        $rules[0] = static::normalizeRule($rules[0]);

        return $rules;
    }

In Validator::validateUsingCustomRule:

    protected function validateUsingCustomRule($attribute, $value, $rule)
    {
        $attribute = $this->replacePlaceholderInString($attribute);

        $value = is_array($value) ? $this->replacePlaceholders($value) : $value;

        if (! $rule->passes($attribute, $value)) {

            $parameters = method_exists($rule, 'parameters') ? $rule->parameters() : [];

            $this->failedRules[$attribute][get_class($rule)] = $parameters;

            $messages = $rule->message();

            $messages = $messages ? (array) $messages : [get_class($rule)];

            foreach ($messages as $message) {
                $this->messages->add($attribute, $this->makeReplacements(
                    $message, $attribute, get_class($rule), $parameters
                ));
            }
        }
    }