Pull Request Tests Requirements #40351
Unanswered
devajmeireles
asked this question in
Q&A
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
I would like to understand how the test requirement for opening/sending a PR works. I'm producing a PR (first time for Laravel) and I've seen that the tests need to be run through
bin/tests.sh
, however when I run it, I just get the error: "MySQL never became available", even though all dockers containers have been powered on and are running without any apparent problems:This error is thrown in the
bin/tests.sh
file:Error by CLI:

It's sad to see a framework the size of Laravel not have any "clear" explanation (by the repository or website) on how tests should be managed.
We might think, "Oh, write the PR and send it without test!" - This is synonymous with wasting time when the team receives the PR and disapproves or denies it for understanding that it is "incomplete".
Does anyone have any explanation that could help me help the Laravel community with some PR's?
C/C @taylorotwell
Beta Was this translation helpful? Give feedback.
All reactions