Desired double data wrapping

[nandi95]

I have created resource for the built in DatabaseNotification

<?php

namespace App\Http\Resources;

use Illuminate\Http\Request;
use Illuminate\Http\Resources\Json\JsonResource;
use Illuminate\Notifications\DatabaseNotification;

/**
 * @property-read DatabaseNotification $resource
 */
class NotificationResource extends JsonResource
{
    /**
     * Transform the resource into an array.
     *
     * @param Request $request
     *
     * @return array
     */
    public function toArray($request): array
    {
        return [
            'id'         => $this->resource->getKey(),
            'data'       => $this->resource->getAttribute('data'),
            'read_at'    => $this->resource->getAttribute('read_at'),
            'created_at' => $this->resource->getAttribute($this->resource->getCreatedAtColumn())->toISOString()
        ];
    }
}

and noticed that it isn't being data wrapped that is because if resource defines a data key it will ignore the wrapping as per the docs
However I would argue that maybe it should be wrapped in 'data' when there are more then one keys returned in the resource.

framework/src/Illuminate/Http/Resources/Json/ResourceResponse.php

Line 84 in 53a9850

return $this->wrapper() && ! array_key_exists($this->wrapper(), $data);

- return $this->wrapper() && ! array_key_exists($this->wrapper(), $data);
+ return $this->wrapper() && ! array_key_exists($this->wrapper(), $data) && count($data) > 1;

Unfortunately I cannot just add a wrapping data key in the resource because that messes up the structure when it comes to pagination/collection. So the workaround for now is:

return response()->json(['data' => new NotificationResource($notification)])

Related:

• Double-wrapping of resource collections that use with #36943