[9.x] Folder "views/vendor" ignore by framework #40893

Stunext · 2022-02-09T15:29:23Z

Stunext
Feb 9, 2022

Laravel Version: 9.0.1
PHP Version: 8.1.2
Ubuntu added
Nginx added

Description:

The "vendor" folder inside views is completely ignored by the framework; this includes views exported by external packages (larecipe); and even internal Laravel views like mail views that result from running "php artisan vendor:publish --tag=laravel-mail".

Changes to these files are not reflected. Even clearing the view cache. These views are still built with the files included in the vendor (composer) folder instead of the published ones.

Steps To Reproduce:

Can be tested running php artisan vendor:publish --tag=laravel-mail

Change some details or style inside "resources/views/vendor/mail/html"

Creatin a example mail: php artisan make:mail OrderShipped --markdown=emails.orders.shipped

Previewing mail in the browser:

Route::get('/mail', function () {
    return new App\Mail\OrderShipped();
});

The changes are not reflected, php artisan view:clear does not solve the problem. This problem is not in Laravel 8.82.0

rodrigopedra · 2022-02-09T15:40:56Z

rodrigopedra
Feb 9, 2022

Just tested with the steps you mentioned, I added a style="color:red;" to the body tag on ./resources/views/vendor/mail/html/layout.blade.php and it worked as expected.

Just for the record, I am running the latest patch version as of this writing:

$ php artisan --version
Laravel Framework 9.0.1

Maybe isn't some third-party package that is overriding it?

4 replies

Stunext Feb 9, 2022
Author

This doesn't work for me on a clean install of Laravel 9.0.1

Stunext Feb 9, 2022
Author

I try same as you. Only works if I change in composer folder:

./vendor/laravel/framework/src/Illuminate/Mail/resources/views/html/layout.blade.php

Not work in:

./resources/views/vendor/mail/html/layout.blade.php

Stunext Feb 9, 2022
Author

What is your version of PHP?

rodrigopedra Feb 9, 2022

@Stunext here you go:

Installation steps

~/code $ php -v
PHP 8.0.15 (cli) (built: Jan 29 2022 07:24:52) ( NTS )
Copyright (c) The PHP Group
Zend Engine v4.0.15, Copyright (c) Zend Technologies
    with Zend OPcache v8.0.15, Copyright (c), by Zend Technologies

~/code $ laravel --version
Laravel Installer 4.2.10

~/code $ laravel new mail-test

Very long output (click to open)

 _                               _
| |                             | |
| |     __ _ _ __ __ ___   _____| |
| |    / _` | '__/ _` \ \ / / _ \ |
| |___| (_| | | | (_| |\ V /  __/ |
|______\__,_|_|  \__,_| \_/ \___|_|

Creating a "laravel/laravel" project at "./mail-test"
Installing laravel/laravel (v9.0.0)
  - Installing laravel/laravel (v9.0.0): Extracting archive
Created project in /home/rodrigo/code/mail-test
> @php -r "file_exists('.env') || copy('.env.example', '.env');"
Loading composer repositories with package information
Updating dependencies
Lock file operations: 109 installs, 0 updates, 0 removals
  - Locking asm89/stack-cors (v2.1.1)
  - Locking brick/math (0.9.3)
  - Locking dflydev/dot-access-data (v3.0.1)
  - Locking doctrine/inflector (2.0.4)
  - Locking doctrine/instantiator (1.4.0)
  - Locking doctrine/lexer (1.2.2)
  - Locking dragonmantank/cron-expression (v3.3.1)
  - Locking egulias/email-validator (3.1.2)
  - Locking facade/ignition-contracts (1.0.2)
  - Locking fakerphp/faker (v1.19.0)
  - Locking filp/whoops (2.14.5)
  - Locking fruitcake/laravel-cors (v2.0.5)
  - Locking graham-campbell/result-type (v1.0.4)
  - Locking guzzlehttp/guzzle (7.4.1)
  - Locking guzzlehttp/promises (1.5.1)
  - Locking guzzlehttp/psr7 (2.1.0)
  - Locking hamcrest/hamcrest-php (v2.0.1)
  - Locking laravel/framework (v9.0.1)
  - Locking laravel/sail (v1.13.2)
  - Locking laravel/sanctum (v2.14.0)
  - Locking laravel/serializable-closure (v1.1.0)
  - Locking laravel/tinker (v2.7.0)
  - Locking league/commonmark (2.2.1)
  - Locking league/config (v1.1.1)
  - Locking league/flysystem (3.0.3)
  - Locking league/mime-type-detection (1.9.0)
  - Locking mockery/mockery (1.5.0)
  - Locking monolog/monolog (2.3.5)
  - Locking myclabs/deep-copy (1.10.2)
  - Locking nesbot/carbon (2.56.0)
  - Locking nette/schema (v1.2.2)
  - Locking nette/utils (v3.2.7)
  - Locking nikic/php-parser (v4.13.2)
  - Locking nunomaduro/collision (v6.1.0)
  - Locking phar-io/manifest (2.0.3)
  - Locking phar-io/version (3.1.1)
  - Locking phpdocumentor/reflection-common (2.2.0)
  - Locking phpdocumentor/reflection-docblock (5.3.0)
  - Locking phpdocumentor/type-resolver (1.6.0)
  - Locking phpoption/phpoption (1.8.1)
  - Locking phpspec/prophecy (v1.15.0)
  - Locking phpunit/php-code-coverage (9.2.10)
  - Locking phpunit/php-file-iterator (3.0.6)
  - Locking phpunit/php-invoker (3.1.1)
  - Locking phpunit/php-text-template (2.0.4)
  - Locking phpunit/php-timer (5.0.3)
  - Locking phpunit/phpunit (9.5.13)
  - Locking psr/container (2.0.2)
  - Locking psr/event-dispatcher (1.0.0)
  - Locking psr/http-client (1.0.1)
  - Locking psr/http-factory (1.0.1)
  - Locking psr/http-message (1.0.1)
  - Locking psr/log (3.0.0)
  - Locking psr/simple-cache (3.0.0)
  - Locking psy/psysh (v0.11.1)
  - Locking ralouphie/getallheaders (3.0.3)
  - Locking ramsey/collection (1.2.2)
  - Locking ramsey/uuid (4.2.3)
  - Locking sebastian/cli-parser (1.0.1)
  - Locking sebastian/code-unit (1.0.8)
  - Locking sebastian/code-unit-reverse-lookup (2.0.3)
  - Locking sebastian/comparator (4.0.6)
  - Locking sebastian/complexity (2.0.2)
  - Locking sebastian/diff (4.0.4)
  - Locking sebastian/environment (5.1.3)
  - Locking sebastian/exporter (4.0.4)
  - Locking sebastian/global-state (5.0.3)
  - Locking sebastian/lines-of-code (1.0.3)
  - Locking sebastian/object-enumerator (4.0.4)
  - Locking sebastian/object-reflector (2.0.4)
  - Locking sebastian/recursion-context (4.0.4)
  - Locking sebastian/resource-operations (3.0.3)
  - Locking sebastian/type (2.3.4)
  - Locking sebastian/version (3.0.2)
  - Locking spatie/backtrace (1.2.1)
  - Locking spatie/flare-client-php (1.0.1)
  - Locking spatie/ignition (1.0.2)
  - Locking spatie/laravel-ignition (1.0.3)
  - Locking symfony/console (v6.0.3)
  - Locking symfony/css-selector (v6.0.3)
  - Locking symfony/deprecation-contracts (v3.0.0)
  - Locking symfony/error-handler (v6.0.3)
  - Locking symfony/event-dispatcher (v6.0.3)
  - Locking symfony/event-dispatcher-contracts (v3.0.0)
  - Locking symfony/finder (v6.0.3)
  - Locking symfony/http-foundation (v6.0.3)
  - Locking symfony/http-kernel (v6.0.4)
  - Locking symfony/mailer (v6.0.3)
  - Locking symfony/mime (v6.0.3)
  - Locking symfony/polyfill-ctype (v1.24.0)
  - Locking symfony/polyfill-intl-grapheme (v1.24.0)
  - Locking symfony/polyfill-intl-idn (v1.24.0)
  - Locking symfony/polyfill-intl-normalizer (v1.24.0)
  - Locking symfony/polyfill-mbstring (v1.24.0)
  - Locking symfony/polyfill-php72 (v1.24.0)
  - Locking symfony/polyfill-php80 (v1.24.0)
  - Locking symfony/polyfill-php81 (v1.24.0)
  - Locking symfony/process (v6.0.3)
  - Locking symfony/routing (v6.0.3)
  - Locking symfony/service-contracts (v3.0.0)
  - Locking symfony/string (v6.0.3)
  - Locking symfony/translation (v6.0.3)
  - Locking symfony/translation-contracts (v3.0.0)
  - Locking symfony/var-dumper (v6.0.3)
  - Locking theseer/tokenizer (1.2.1)
  - Locking tijsverkoyen/css-to-inline-styles (2.2.4)
  - Locking vlucas/phpdotenv (v5.4.1)
  - Locking voku/portable-ascii (2.0.0)
  - Locking webmozart/assert (1.10.0)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 109 installs, 0 updates, 0 removals
  - Installing doctrine/inflector (2.0.4): Extracting archive
  - Installing doctrine/lexer (1.2.2): Extracting archive
  - Installing symfony/polyfill-ctype (v1.24.0): Extracting archive
  - Installing webmozart/assert (1.10.0): Extracting archive
  - Installing dragonmantank/cron-expression (v3.3.1): Extracting archive
  - Installing symfony/deprecation-contracts (v3.0.0): Extracting archive
  - Installing psr/container (2.0.2): Extracting archive
  - Installing fakerphp/faker (v1.19.0): Extracting archive
  - Installing symfony/polyfill-mbstring (v1.24.0): Extracting archive
  - Installing symfony/http-foundation (v6.0.3): Extracting archive
  - Installing psr/event-dispatcher (1.0.0): Extracting archive
  - Installing symfony/event-dispatcher-contracts (v3.0.0): Extracting archive
  - Installing symfony/event-dispatcher (v6.0.3): Extracting archive
  - Installing symfony/var-dumper (v6.0.3): Extracting archive
  - Installing psr/log (3.0.0): Extracting archive
  - Installing symfony/error-handler (v6.0.3): Extracting archive
  - Installing symfony/http-kernel (v6.0.4): Extracting archive
  - Installing voku/portable-ascii (2.0.0): Extracting archive
  - Installing symfony/polyfill-php80 (v1.24.0): Extracting archive
  - Installing phpoption/phpoption (1.8.1): Extracting archive
  - Installing graham-campbell/result-type (v1.0.4): Extracting archive
  - Installing vlucas/phpdotenv (v5.4.1): Extracting archive
  - Installing symfony/css-selector (v6.0.3): Extracting archive
  - Installing tijsverkoyen/css-to-inline-styles (2.2.4): Extracting archive
  - Installing symfony/routing (v6.0.3): Extracting archive
  - Installing symfony/process (v6.0.3): Extracting archive
  - Installing symfony/polyfill-php72 (v1.24.0): Extracting archive
  - Installing symfony/polyfill-intl-normalizer (v1.24.0): Extracting archive
  - Installing symfony/polyfill-intl-idn (v1.24.0): Extracting archive
  - Installing symfony/mime (v6.0.3): Extracting archive
  - Installing symfony/service-contracts (v3.0.0): Extracting archive
  - Installing egulias/email-validator (3.1.2): Extracting archive
  - Installing symfony/mailer (v6.0.3): Extracting archive
  - Installing symfony/finder (v6.0.3): Extracting archive
  - Installing symfony/polyfill-intl-grapheme (v1.24.0): Extracting archive
  - Installing symfony/string (v6.0.3): Extracting archive
  - Installing symfony/console (v6.0.3): Extracting archive
  - Installing symfony/polyfill-php81 (v1.24.0): Extracting archive
  - Installing ramsey/collection (1.2.2): Extracting archive
  - Installing brick/math (0.9.3): Extracting archive
  - Installing ramsey/uuid (4.2.3): Extracting archive
  - Installing psr/simple-cache (3.0.0): Extracting archive
  - Installing symfony/translation-contracts (v3.0.0): Extracting archive
  - Installing symfony/translation (v6.0.3): Extracting archive
  - Installing nesbot/carbon (2.56.0): Extracting archive
  - Installing monolog/monolog (2.3.5): Extracting archive
  - Installing league/mime-type-detection (1.9.0): Extracting archive
  - Installing league/flysystem (3.0.3): Extracting archive
  - Installing nette/utils (v3.2.7): Extracting archive
  - Installing nette/schema (v1.2.2): Extracting archive
  - Installing dflydev/dot-access-data (v3.0.1): Extracting archive
  - Installing league/config (v1.1.1): Extracting archive
  - Installing league/commonmark (2.2.1): Extracting archive
  - Installing laravel/serializable-closure (v1.1.0): Extracting archive
  - Installing laravel/framework (v9.0.1): Extracting archive
  - Installing asm89/stack-cors (v2.1.1): Extracting archive
  - Installing fruitcake/laravel-cors (v2.0.5): Extracting archive
  - Installing psr/http-message (1.0.1): Extracting archive
  - Installing psr/http-client (1.0.1): Extracting archive
  - Installing ralouphie/getallheaders (3.0.3): Extracting archive
  - Installing psr/http-factory (1.0.1): Extracting archive
  - Installing guzzlehttp/psr7 (2.1.0): Extracting archive
  - Installing guzzlehttp/promises (1.5.1): Extracting archive
  - Installing guzzlehttp/guzzle (7.4.1): Extracting archive
  - Installing laravel/sail (v1.13.2): Extracting archive
  - Installing laravel/sanctum (v2.14.0): Extracting archive
  - Installing nikic/php-parser (v4.13.2): Extracting archive
  - Installing psy/psysh (v0.11.1): Extracting archive
  - Installing laravel/tinker (v2.7.0): Extracting archive
  - Installing hamcrest/hamcrest-php (v2.0.1): Extracting archive
  - Installing mockery/mockery (1.5.0): Extracting archive
  - Installing filp/whoops (2.14.5): Extracting archive
  - Installing facade/ignition-contracts (1.0.2): Extracting archive
  - Installing nunomaduro/collision (v6.1.0): Extracting archive
  - Installing phpdocumentor/reflection-common (2.2.0): Extracting archive
  - Installing phpdocumentor/type-resolver (1.6.0): Extracting archive
  - Installing phpdocumentor/reflection-docblock (5.3.0): Extracting archive
  - Installing sebastian/version (3.0.2): Extracting archive
  - Installing sebastian/type (2.3.4): Extracting archive
  - Installing sebastian/resource-operations (3.0.3): Extracting archive
  - Installing sebastian/recursion-context (4.0.4): Extracting archive
  - Installing sebastian/object-reflector (2.0.4): Extracting archive
  - Installing sebastian/object-enumerator (4.0.4): Extracting archive
  - Installing sebastian/global-state (5.0.3): Extracting archive
  - Installing sebastian/exporter (4.0.4): Extracting archive
  - Installing sebastian/environment (5.1.3): Extracting archive
  - Installing sebastian/diff (4.0.4): Extracting archive
  - Installing sebastian/comparator (4.0.6): Extracting archive
  - Installing sebastian/code-unit (1.0.8): Extracting archive
  - Installing sebastian/cli-parser (1.0.1): Extracting archive
  - Installing phpunit/php-timer (5.0.3): Extracting archive
  - Installing phpunit/php-text-template (2.0.4): Extracting archive
  - Installing phpunit/php-invoker (3.1.1): Extracting archive
  - Installing phpunit/php-file-iterator (3.0.6): Extracting archive
  - Installing theseer/tokenizer (1.2.1): Extracting archive
  - Installing sebastian/lines-of-code (1.0.3): Extracting archive
  - Installing sebastian/complexity (2.0.2): Extracting archive
  - Installing sebastian/code-unit-reverse-lookup (2.0.3): Extracting archive
  - Installing phpunit/php-code-coverage (9.2.10): Extracting archive
  - Installing doctrine/instantiator (1.4.0): Extracting archive
  - Installing phpspec/prophecy (v1.15.0): Extracting archive
  - Installing phar-io/version (3.1.1): Extracting archive
  - Installing phar-io/manifest (2.0.3): Extracting archive
  - Installing myclabs/deep-copy (1.10.2): Extracting archive
  - Installing phpunit/phpunit (9.5.13): Extracting archive
  - Installing spatie/backtrace (1.2.1): Extracting archive
  - Installing spatie/flare-client-php (1.0.1): Extracting archive
  - Installing spatie/ignition (1.0.2): Extracting archive
  - Installing spatie/laravel-ignition (1.0.3): Extracting archive
52 package suggestions were added by new dependencies, use `composer suggest` to see details.
Generating optimized autoload files
> Illuminate\Foundation\ComposerScripts::postAutoloadDump
> @php artisan package:discover --ansi
Discovered Package: fruitcake/laravel-cors
Discovered Package: laravel/sail
Discovered Package: laravel/sanctum
Discovered Package: laravel/tinker
Discovered Package: nesbot/carbon
Discovered Package: nunomaduro/collision
Discovered Package: spatie/laravel-ignition
Package manifest generated successfully.
78 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
> @php artisan vendor:publish --tag=laravel-assets --ansi --force
No publishable resources for tag [laravel-assets].
Publishing complete.
> @php artisan key:generate --ansi
Application key set successfully.

Application ready! Build something amazing.

~/code $ cd mail-test/

~/code/mail-test $ php artisan --version
Laravel Framework 9.0.1

~/code/mail-test $ php artisan vendor:publish --tag=laravel-mail
Copied Directory [/vendor/laravel/framework/src/Illuminate/Mail/resources/views] To [/resources/views/vendor/mail]
Publishing complete.

~/code/mail-test $ php artisan make:mail OrderShipped --markdown=emails.orders.shipped
Mail created successfully.

~/code/mail-test $ vi resources/views/vendor/mail/
html/ text/ 

~/code/mail-test $ vi resources/views/vendor/mail/html/
button.blade.php   footer.blade.php   header.blade.php   layout.blade.php   message.blade.php  panel.blade.php    subcopy.blade.php  table.blade.php    themes/

~/code/mail-test $ vi resources/views/vendor/mail/html/layout.blade.php 

~/code/mail-test $ vi routes/web.php 

~/code/mail-test $ php artisan serve
Starting Laravel development server: http://127.0.0.1:8000
[Wed Feb  9 15:10:57 2022] PHP 8.0.15 Development Server (http://127.0.0.1:8000) started
[Wed Feb  9 15:10:59 2022] 127.0.0.1:41446 Accepted
[Wed Feb  9 15:10:59 2022] 127.0.0.1:41446 Closing

Edits

On resources/views/vendor/mail/html/layout.blade.php:

- 26: <body>
+ 26: <body style="color: red;">

number 26 refers to the line number on this file

On routes/web.php

- 17:     return view('welcome');
+ 17:     return new App\Mail\OrderShipped();

number 17 refers to the line number on this file

Output

driesvints · 2022-02-09T16:07:52Z

driesvints
Feb 9, 2022
Maintainer

"resources/views/vendor/mail/html"

This directory is reserved for third party libraries. It should not contain any application views unless you're publishing views from a third party library.

2 replies

Stunext Feb 9, 2022
Author

In a clean installation I just use php artisan vendor:publish --tag=laravel-mail. Not third party libraries. I try to change laravel default email CSS

driesvints Feb 9, 2022
Maintainer

I'll have a look tomorrow.

Stunext · 2022-02-09T21:00:49Z

Stunext
Feb 9, 2022
Author

I have discovered the problem:

In Laravel Framework 8.83.0
The ./resources/views/vendor/ folder permissions are: drwxr-xr-x

In Laravel Framework 9.0.1
The ./resources/views/vendor/ folder permissions are: drwx------

In both cases with clean installation

5 replies

rodrigopedra Feb 9, 2022

Did you see may reply here:

#40893 (reply in thread)

Also, how are you installing it on your machine?

Stunext Feb 9, 2022
Author

I am installing it with composer create-project laravel/laravel example-app

rodrigopedra Feb 10, 2022

I am installing it with the laravel installer.

There shouldn’t be any difference, but you can try installing it and see if it makes a difference:

https://laravel.com/docs/9.x#the-laravel-installer

driesvints Feb 10, 2022
Maintainer

I can confirm this. Investigating.

driesvints Feb 10, 2022
Maintainer

I've sent in a PR for this: #40918

[9.x] Folder "views/vendor" ignore by framework #40893

Uh oh!

Uh oh!

Stunext Feb 9, 2022

Description:

Steps To Reproduce:

Replies: 3 comments · 11 replies

Uh oh!

Uh oh!

rodrigopedra Feb 9, 2022

Uh oh!

Stunext Feb 9, 2022 Author

Uh oh!

Stunext Feb 9, 2022 Author

Uh oh!

Stunext Feb 9, 2022 Author

Uh oh!

rodrigopedra Feb 9, 2022

Installation steps

Edits

Output

Uh oh!

driesvints Feb 9, 2022 Maintainer

Uh oh!

Stunext Feb 9, 2022 Author

Uh oh!

driesvints Feb 9, 2022 Maintainer

Uh oh!

Uh oh!

Stunext Feb 9, 2022 Author

Uh oh!

rodrigopedra Feb 9, 2022

Uh oh!

Stunext Feb 9, 2022 Author

Uh oh!

rodrigopedra Feb 10, 2022

Uh oh!

driesvints Feb 10, 2022 Maintainer

Uh oh!

driesvints Feb 10, 2022 Maintainer

Stunext
Feb 9, 2022

Replies: 3 comments 11 replies

rodrigopedra
Feb 9, 2022

Stunext Feb 9, 2022
Author

Stunext Feb 9, 2022
Author

Stunext Feb 9, 2022
Author

driesvints
Feb 9, 2022
Maintainer

Stunext Feb 9, 2022
Author

driesvints Feb 9, 2022
Maintainer

Stunext
Feb 9, 2022
Author

Stunext Feb 9, 2022
Author

driesvints Feb 10, 2022
Maintainer

driesvints Feb 10, 2022
Maintainer