Introduce generics to framework #41597

MariusSpring · 2022-03-21T12:02:36Z

MariusSpring
Mar 21, 2022

Hi!

PhpStorm has recently added support for generics through docblocks. I believe utilizing this will greatly improve developer experience. Take the following example:

Framework changes:

if (! function_exists('app')) {
    /**
     * Get the available container instance.
     *
     * @template T
     * 
     * @param class-string<T>|null  $abstract
     * @param array  $parameters
     * @return T|\Illuminate\Contracts\Foundation\Application
     */
    function app($abstract = null, array $parameters = [])
    {
        if (is_null($abstract)) {
            return Container::getInstance();
        }

        return Container::getInstance()->make($abstract, $parameters);
    }
}

In app:

// PHP storm (and other IDEs?) is able to autocomplete the `findPopular` function as 
// above we declare that `app` returns an instance of the class string we provide.
$popularPosts = app(BlogPostRepository::class)->findPopular(amount: 10);

This could slowely be incorporated bit by bit, however, I believe the most important one is the app function for resolving container instances.

Thoughts?