composer dump-autoload creates .tmp files in the bootstrap/cache directory

[MircoBabin]

• Laravel Version: 9.26.1
• PHP Version: 8.1.7
• Database Driver & Version: MySql 8.0.16
• OS: Windows

Description:

In the bootstrap/cache directory .tmp files are created.

Steps To Reproduce:

• Make the bootstrap/cache/packages.php file readonly. e.g. attrib +r bootstrap\cache\packages.php
• Execute php composer.phar dump-autoload --no-dev

Generating optimized autoload files
> Illuminate\Foundation\ComposerScripts::postAutoloadDump
> @php artisan package:discover --ansi

   INFO  Discovering packages.


In Filesystem.php line 214:

  rename(D:\Projects\Webpage\tripportals\bootstrap\cache\pacB19E.tmp,D:\Projects\Webpage\tripportals\bootstrap\cache\
  packages.php): Toegang geweigerd (code: 5)


Script @php artisan package:discover --ansi handling the post-autoload-dump event returned with error code 1

• Observe a .tmp file is created in the bootstrap/cache directory

Contents of /bootstrap/cache/pacB19E.tmp:

<?php return array (
  'intervention/image' => 
  array (
    'providers' => 
    array (
      0 => 'Intervention\\Image\\ImageServiceProvider',
    ),
    'aliases' => 
    array (
      'Image' => 'Intervention\\Image\\Facades\\Image',
    ),
  ),
  'laravel/socialite' => 
  array (
    'providers' => 
    array (
      0 => 'Laravel\\Socialite\\SocialiteServiceProvider',
    ),
    'aliases' => 
    array (
      'Socialite' => 'Laravel\\Socialite\\Facades\\Socialite',
    ),
  ),
  'laravel/tinker' => 
  array (
    'providers' => 
    array (
      0 => 'Laravel\\Tinker\\TinkerServiceProvider',
    ),
  ),
  'laravelcollective/html' => 
  array (
    'providers' => 
    array (
      0 => 'Collective\\Html\\HtmlServiceProvider',
    ),
    'aliases' => 
    array (
      'Form' => 'Collective\\Html\\FormFacade',
      'Html' => 'Collective\\Html\\HtmlFacade',
    ),
  ),
  'maatwebsite/excel' => 
  array (
    'providers' => 
    array (
      0 => 'Maatwebsite\\Excel\\ExcelServiceProvider',
    ),
    'aliases' => 
    array (
      'Excel' => 'Maatwebsite\\Excel\\Facades\\Excel',
    ),
  ),
  'nesbot/carbon' => 
  array (
    'providers' => 
    array (
      0 => 'Carbon\\Laravel\\ServiceProvider',
    ),
  ),
  'nunomaduro/termwind' => 
  array (
    'providers' => 
    array (
      0 => 'Termwind\\Laravel\\TermwindServiceProvider',
    ),
  ),
  'socialiteproviders/manager' => 
  array (
    'providers' => 
    array (
      0 => 'SocialiteProviders\\Manager\\ServiceProvider',
    ),
  ),
);

Problem analysis

1. The problem starts in vendor\laravel\framework\src\Illuminate\Foundation\PackageManifest.php in function write(...).

   framework/src/Illuminate/Foundation/PackageManifest.php

   Line 175 in cad86c1

   protected function write(array $manifest)

2. This calls $this->files->replace(...).

   framework/src/Illuminate/Foundation/PackageManifest.php

   Lines 181 to 183 in cad86c1

   	$this->files->replace(
   	$this->manifestPath, '<?php return '.var_export($manifest, true).';'
   	);

3. vendor\laravel\framework\src\Illuminate\Filesystem\Filesystem.php in function replace() first creates a temporary file.

   framework/src/Illuminate/Filesystem/Filesystem.php

   Lines 193 to 215 in cad86c1

   	/**
   	* Write the contents of a file, replacing it atomically if it already exists.
   	*
   	* @param string $path
   	* @param string $content
   	* @return void
   	*/
   	public function replace($path, $content)
   	{
   	// If the path already exists and is a symlink, get the real path...
   	clearstatcache(true, $path);
   	$path = realpath($path) ?: $path;
   	$tempPath = tempnam(dirname($path), basename($path));
   	// Fix permissions of tempPath because `tempnam()` creates it with permissions set to 0600...
   	chmod($tempPath, 0777 - umask());
   	file_put_contents($tempPath, $content);
   	rename($tempPath, $path);
   	}

4. And finally renames the tempfile to the file to be replaced.

   framework/src/Illuminate/Filesystem/Filesystem.php

   Line 214 in cad86c1

   rename($tempPath, $path);

5. But if this rename() fails, the created tempfile is not removed.

[MircoBabin]

@driesvints: I don't know why this is moved to discussions from #45209? Because this is a bug in FileSystem replace() function.

I'm not seeking for an answer, I'm reporting a bug.

But if Laravel is not wanting bug reports anymore, ok that's fine with me.