Problem testing Mailable with assertHasAttachmentFromStorage

[michaelklopf]

Hi there,

I have a problem with testing a mailable that attaches an attachment from Storage. Like this

    public function attachments()
    {
        return [
            Attachment::fromStorageDisk('minio', $this->attachment->getFilepath())
                ->as($this->attachment->name)
                ->withMime($this->attachment->type),
        ];
     }

The mailable has an assertion for this, so the test does

        $mailable->assertHasAttachmentFromStorage($attachment->getFilepath(), $attachment->name, ['mime' => $attachment->type]);

This always returns

Did not find the expected attachment.
Failed asserting that false is true.

The assertion is stepping through a couple methods in the Illuminate/Mail/Mailable.php. hasAttachmentFromStorageDisk() is checking in the $this->diskAttachments for the attachments. But this is never set.

diskAttachments is set in the attachFromStorageDisk function, which is called by the attachFromStorage function. This function is nowhere used though, especially not by me. I guess I should do something like $mailable->attachFromStorage?

Which leads me to believe, either I'm wrong in how I read the docs and how to use mailables, or the docs are incomplete.

Any ideas?

[Lloople]

I'm having the same issue. For now I'll just build assertions for the attachments() method, but I would like to know how to properly test this.

[GregOstry]

I can confirm it, also have this problem.

Did not find the expected attachment.
Failed asserting that false is true.

i think this is the part where the failure is:

public function hasAttachment($file, array $options = [])
    {
        if ($file instanceof Attachable) {
            $file = $file->toMailAttachment();
        }

        if ($file instanceof Attachment && $this->hasEnvelopeAttachment($file, $options)) {
            return true;
        }

        if ($file instanceof Attachment) {
            $parts = $file->attachWith(
                fn ($path) => [$path, [
                    'as' => $options['as'] ?? $file->as,
                    'mime' => $options['mime'] ?? $file->mime,
                ]],
                fn ($data) => $this->hasAttachedData($data(), $options['as'] ?? $file->as, ['mime' => $options['mime'] ?? $file->mime])
            );

            if ($parts === true) {
                return true;
            }

            [$file, $options] = $parts === false
                ? [null, []]
                : $parts;
        }
        
        return collect($this->attachments)->contains(
            fn ($attachment) => $attachment['file'] === $file && array_filter($attachment['options']) === array_filter($options)
        );
    }