You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Apologies if this has already been asked and answered, however I could not find anything.
The Coding Style section of the contribution guide states @param and @return should be omitted when they are redundant due to the native types.
Throughout the framework we do the opposite, for example the Stringable API.
Is there a reason for not adding the type declarations or would a pull request be welcome to add the type declarations throughout the framework? Likely targeted at version 11 or even 12 to avoid breaking changes on users extending the updated classes.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
Apologies if this has already been asked and answered, however I could not find anything.
The Coding Style section of the contribution guide states @param and @return should be omitted when they are redundant due to the native types.
Throughout the framework we do the opposite, for example the Stringable API.
Is there a reason for not adding the type declarations or would a pull request be welcome to add the type declarations throughout the framework? Likely targeted at version 11 or even 12 to avoid breaking changes on users extending the updated classes.
Beta Was this translation helpful? Give feedback.
All reactions