Replies: 1 comment
-
I agree. But I suggest php 8 attributes for that. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
A few months ago I submitted a PR that uses the array shape notation to write the return value in more detail.
Unfortunately it was closed.
However, I think such detailed types are useful to improve the readability of the framework code. This is especially true where arrays are complicated, such as the above. In fact, there are already several places in the framework where array-shape is used.
Any opinions on this?
I would like to bring the above PR to merge. Furthermore, if possible, I would like to apply the array shape typings to other types as well.
Beta Was this translation helpful? Give feedback.
All reactions