Add whereWeekday and whereWeekdayIn to the Query Builder

[Arielt99]

Hi,

for a date based where, the framework seem to only support the types: year, month, day and time, while as far as I know most of the database management system also support the weekday.
I personnaly often have to create a macro for whereWeekday and whereWeekdayIn.

I'm prepared to do it, but I'd rather gather some opinions beforehand.

[shaedrich]

Would you mind sharing your macros?

[shaedrich]

Thanks for sharing these!

Can't you just do $attribute = $this->qualifyColumn($attribute);?

[Arielt99]

Yes you can, it's way better actually ! I didn't know this one, thanks!

[shaedrich]

You're welcome!

[shaedrich]

I'm prepared to do it, but I'd rather gather some opinions beforehand. […] Sure thing, it's made with mysql in mind, if you use another database management system that don't support weekday() you can adapt it.

If you are going to submit a PR on that matter, good luck with that (you gonna need it)—this confidence is admirable. Even though, it's common practise (and potentially dangerous in my opinion (not that Taylor Otwell would care)) in Laravel to silently discard database actions that aren't supported by the engine in question, I expect the response to be that they don't want to implement something that isn't supported by each and every database engine.

[Arielt99]

If I were to do it, it would be a cleaner way, within the different grammar classes like it's done for the other date based query.

[henzeb]

it's best if you look at packages. something like https://github.com/omarelnaghy/lara-date-filter or https://github.com/laracraft-tech/laravel-date-scopes

[Arielt99]

I already have my macros for it. My goal with this topic is to implement it in the framework so everyone can use it without having the need to add a dependency.

[henzeb]

But still, you need to implement it for every database. It probably means to add methods to the grammar classes... Lots of tests.

[Arielt99]

Since it's just adding a supported type to the existing functions, it don't seem that big, but I might have missed some stuff that would make it more difficult.

[parallels999]

I'm prepared to do it, but I'd rather gather some opinions beforehand.

Taylor will close it faster than it will take you to do it. just use the macros, without any review

[shaedrich]

One could say, it's his signature move

[parallels999]

Always

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

[shaedrich]

Well, after all, it's "A Community Framework" in name only