Models using stringable primary key objects in MorpTo result in TypeError

[naxvog]

I am using Ulid objects as primary keys. Those implement the __toString magic method. I noticed that a morphTo relationship without an explicit ownerKey results in a type error.

Lines in question:

framework/src/Illuminate/Database/Eloquent/Relations/MorphTo.php

Lines 213 to 224 in 4b4b1e4

	protected function matchToMorphParents($type, Collection $results)
	{
	foreach ($results as $result) {
	$ownerKey = ! is_null($this->ownerKey) ? $this->getDictionaryKey($result->{$this->ownerKey}) : $result->getKey();
	if (isset($this->dictionary[$type][$ownerKey])) {
	foreach ($this->dictionary[$type][$ownerKey] as $model) {
	$model->setRelation($this->relationName, $result);
	}
	}
	}
	}

getKey will retrieve the stringable object, but PHP does not automatically convert it to a string when using it for array access resulting in my type error ("Illegal offset type in isset or empty").

I noticed that the getDictionaryKey will try to call __toString.

Currently, I use a custom trait to set the ownerKey using named parameters to avoid this issue. A simple string cast of $ownerKey would fix my issue.

I know this is more of a bug report, but I am quite new to Laravel and I fear I might miss something obvious.