Feature idea: new helper / utility for returning percentage from two values

[sts-ryan-holton]

👋 Hi,

I'd like to propose a new feature request for being able to return a percentage back when two inputs are given. In my example, I've created a function in my application that's globally accessible but wondered if this kind of function could be ported into a nice helper or utility for Laravel, for example:

Here's my function:

function conversion_from($totals, $conversions, $formatted = true)
{
    if (! $totals || ! $conversions) {
        return 0;
    }

    $conversionRate = round($conversions / $totals, 3) * 100;

    if (! $formatted) {
        return floatval(number_format($conversionRate, 2));
    }

    return number_format(floatval($conversionRate), 2, '.', ',');
}

In this example, given the following:

var_dump(conversion_from(100, 50)); // returns 50 as int
var_dump(conversion_from(100, 50, true)); // returns 50.00 as string

I've created a demo here

I was hoping Laravel could introduce some utility like:

Percentage::from(100, 50) // output 50 as int
Percentage::from(100, 50)->toString() // 50.00 as string
Percentage::from(100, 50)->format('custom format') // handle custom
Percentage::from(100, 50)->toString()->append('%') // 50.00% as string with symbol
Percentage::from(100, 50, 2)->toString() // 50.00 as string with decimal place

[henzeb]

Sounds more of a Number thing.

[sts-ryan-holton]

Sure. So could maybe be a method on the Number utility?

[shaedrich]

You'd probably want to

• have an option to pass in the number of decimal places you want to be displayed
• respect locale settings of the decimal separator and the thousands separator

[sts-ryan-holton]

Sounds good. Hopefully someone is able to implement

[ghost]

@sts-ryan-holton Hi. What value does this bring that compensates for the overhead it comes with? Why is number_format not enough?

[sts-ryan-holton]

number_format doesn't do the logical calculations that I intended for this percentage function. Number format simply formats a number. Did you have any methods in Laravel that can do the same division followed by the format?

[ghost]

No. That is the point. I used number format for the logic I needed, when I needed it.

[shaedrich]

I'm curious about format() and append(): I mean, are there really so many possibilities that one would allow for passing an arbitrary string?