Add $this to attribute callback to access other model properties

[ben221199]

framework/src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php

Line 706 in 9d7c869

}, $value, $this->attributes);

In the line above, only $value and $this->attributes are passed to the closure. However, I think it would be useful to add $this as third parameter, so that I also can access other model properties, like relations. Now I only can access attributes.

[ghost]

Hi. A trait is not aware where it is being used so your desire is not recommended.

[ghost]

Or you can try to use $this in that callback because it should work. You may test it out.

[ben221199]

If I remember correctly, that failed. I will test it again today.

[ben221199]

Using $this when not in object context

[ben221199]

The get_defined_vars() only gives $value and $attributes.

[ghost]

The setting the relation you need as attribute is the only way that I can think of.

[henzeb]

you can of course bind your Closure to $this when passing it to the Attribute?

Attribute::get(
    Closure::bind(
        function(){}, 
        $this
    )
);

or

Attribute::get(
    (function(){})->bindTo($this)
);

[ben221199]

Is that the same as $record = $this; static function(mixed $value,array $attributes) use($record){ /*code*/ }?

[ben221199]

Never mind.

[ben221199]

Okay, I know the problem. This was my code I hoped would work:

protected function nameFinal(): Attribute{
	return Attribute::make(static function(mixed $value,array $attributes){
		dump(get_defined_vars(),$this);
	})->shouldCache();
}

But this didn't work, so I made it like this:

protected function nameFinal(): Attribute{
	$record = $this;
	return Attribute::make(static function(mixed $value,array $attributes) use($record){
		dump(get_defined_vars(),$record);
	})->shouldCache();
}

However, it can be much simpler. First of all, get_defined_vars() will not list $this, so only $value and $attributes are visible. It isn't a good function to see if you have access to $this. The real problem was that I used static function, which doesn't allow $this. Removing the static keyword makes it possible to use $this. I don't even have to use bindTo() on the closure.

The new code looks like this:

protected function nameFinal(): Attribute{
	return Attribute::make(function(mixed $value,array $attributes){
		dump($this);
	})->shouldCache();
}

[ghost]

@ben221199 Thanks for asking this question in an incomplete manner :) And I'm not joking. I learned new things from this thread.

[ben221199]

Do you mean I did a pore job on asking a question? 😂

[ghost]

I was unaware that you can declare a callback static for example. Also that you can manually bind it. I knew from macros that this is available in the callback.